You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by cm...@apache.org on 2012/11/13 18:32:00 UTC
svn commit: r1408849 - /subversion/trunk/subversion/libsvn_ra_serf/update.c
Author: cmpilato
Date: Tue Nov 13 17:31:59 2012
New Revision: 1408849
URL: http://svn.apache.org/viewvc?rev=1408849&view=rev
Log:
* subversion/libsvn_ra_serf/update.c
(end_report): Remove redundant boolean assignment ("if (X) { X = TRUE }").
Modified:
subversion/trunk/subversion/libsvn_ra_serf/update.c
Modified: subversion/trunk/subversion/libsvn_ra_serf/update.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/update.c?rev=1408849&r1=1408848&r2=1408849&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/update.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/update.c Tue Nov 13 17:31:59 2012
@@ -1969,9 +1969,6 @@ end_report(svn_ra_serf__xml_parser_t *pa
*/
if (info->dir->fetch_props)
{
- /* Unconditionally set fetch_props now. */
- info->dir->fetch_props = TRUE;
-
SVN_ERR(svn_ra_serf__deliver_props(&info->dir->propfind_handler,
info->dir->props, ctx->sess,
get_best_connection(ctx),
Re: svn commit: r1408849 -
/subversion/trunk/subversion/libsvn_ra_serf/update.c
Posted by Stefan Sperling <st...@elego.de>.
On Tue, Nov 13, 2012 at 02:33:09PM -0500, C. Michael Pilato wrote:
> On 11/13/2012 02:21 PM, Stefan Sperling wrote:
> > Are you sure this is not a bug checking the wrong X or setting the wrong
> > X to TRUE? I don't know ra_serf very well so this isn't obvious to me.
>
> I'm pretty sure it was a bit of accidental fallout from some code
> reworking/refactoring I did back when I was working on teaching ra_serf to
> ask mod_dav_svn to include all properties in the main REPORT response.
OK, thanks!
Re: svn commit: r1408849 - /subversion/trunk/subversion/libsvn_ra_serf/update.c
Posted by "C. Michael Pilato" <cm...@collab.net>.
On 11/13/2012 02:21 PM, Stefan Sperling wrote:
> On Tue, Nov 13, 2012 at 05:32:00PM -0000, cmpilato@apache.org wrote:
>> Author: cmpilato
>> Date: Tue Nov 13 17:31:59 2012
>> New Revision: 1408849
>>
>> URL: http://svn.apache.org/viewvc?rev=1408849&view=rev
>> Log:
>> * subversion/libsvn_ra_serf/update.c
>> (end_report): Remove redundant boolean assignment ("if (X) { X = TRUE }").
>
> Are you sure this is not a bug checking the wrong X or setting the wrong
> X to TRUE? I don't know ra_serf very well so this isn't obvious to me.
I'm pretty sure it was a bit of accidental fallout from some code
reworking/refactoring I did back when I was working on teaching ra_serf to
ask mod_dav_svn to include all properties in the main REPORT response.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Enterprise Cloud Development
Re: svn commit: r1408849 -
/subversion/trunk/subversion/libsvn_ra_serf/update.c
Posted by Stefan Sperling <st...@elego.de>.
On Tue, Nov 13, 2012 at 05:32:00PM -0000, cmpilato@apache.org wrote:
> Author: cmpilato
> Date: Tue Nov 13 17:31:59 2012
> New Revision: 1408849
>
> URL: http://svn.apache.org/viewvc?rev=1408849&view=rev
> Log:
> * subversion/libsvn_ra_serf/update.c
> (end_report): Remove redundant boolean assignment ("if (X) { X = TRUE }").
Are you sure this is not a bug checking the wrong X or setting the wrong
X to TRUE? I don't know ra_serf very well so this isn't obvious to me.
> @@ -1969,9 +1969,6 @@ end_report(svn_ra_serf__xml_parser_t *pa
> */
> if (info->dir->fetch_props)
> {
> - /* Unconditionally set fetch_props now. */
> - info->dir->fetch_props = TRUE;
> -