You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/15 07:51:45 UTC

[GitHub] [superset] ktmud commented on a change in pull request #13123: fix: add the untranslated text content of Chart page, Sql Editor page and some dashboard label in messages.pot

ktmud commented on a change in pull request #13123:
URL: https://github.com/apache/superset/pull/13123#discussion_r575995433



##########
File path: superset-frontend/src/dashboard/components/Header.jsx
##########
@@ -482,7 +482,7 @@ class Header extends React.PureComponent {
             <>
               <span
                 role="button"
-                title="Edit dashboard"
+                title={t('Edit Dashboard')}

Review comment:
       We use sentence case for most UI elements: https://github.com/apache/superset/blob/master/CONTRIBUTING.md#capitalization-guidelines




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org