You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/05/07 16:48:27 UTC
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5019: GEODE-8076: simplify redis concurrency code
dschneider-pivotal commented on a change in pull request #5019:
URL: https://github.com/apache/geode/pull/5019#discussion_r421647719
##########
File path: geode-assembly/geode-assembly-test/src/main/java/org/apache/geode/rest/internal/web/controllers/PutKeyFunction.java
##########
@@ -30,6 +30,7 @@
private static final String ID = "PutKeyFunction";
+ @SuppressWarnings("unchecked")
@Override
Review comment:
I have removed this change. I don't know how it snuck in. It caused a bunch of merge conflicts. The build is fine without this change. If someone wants to clean this test code up I think it should be on another PR.
##########
File path: geode-assembly/geode-assembly-test/src/main/java/org/apache/geode/rest/internal/web/controllers/GetAllEntries.java
##########
@@ -29,6 +29,7 @@
public class GetAllEntries implements Function {
+ @SuppressWarnings("unchecked")
Review comment:
I have removed this change. I don't know how it snuck in. It caused a bunch of merge conflicts. The build is fine without this change. If someone wants to clean this test code up I think it should be on another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org