You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2016/06/21 23:41:53 UTC
Review Request 49052: Insert overwrite does not work in HBase tables:
stats is not updated
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49052/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
HIVE-14028
Diffs
-----
hbase-handler/src/test/queries/positive/hbasestats.q PRE-CREATION
hbase-handler/src/test/results/positive/hbasestats.q.out PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 774cc2b
Diff: https://reviews.apache.org/r/49052/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 49052: Insert overwrite does not work in HBase
tables: stats is not updated
Posted by pengcheng xiong <px...@hortonworks.com>.
> On June 22, 2016, 3:24 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 6531
> > <https://reviews.apache.org/r/49052/diff/1/?file=1427062#file1427062line6531>
> >
> > instead of new HashMap(),
> > mapProp = tab.getParameters() != null ? tab.getParameters() : new HashMap<>()
> > in which case we will overwrite only column_stats properties and preserve the rest (if there were any).
We do not need to load the existing ones what we want to keep. We only need to specify the ones that we want to delete. Server will automatically handle it.
- pengcheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49052/#review139071
-----------------------------------------------------------
On June 21, 2016, 11:41 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49052/
> -----------------------------------------------------------
>
> (Updated June 21, 2016, 11:41 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14028
>
>
> Diffs
> -----
>
> hbase-handler/src/test/queries/positive/hbasestats.q PRE-CREATION
> hbase-handler/src/test/results/positive/hbasestats.q.out PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 774cc2b
>
> Diff: https://reviews.apache.org/r/49052/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 49052: Insert overwrite does not work in HBase
tables: stats is not updated
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49052/#review139071
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 6531)
<https://reviews.apache.org/r/49052/#comment204227>
instead of new HashMap(),
mapProp = tab.getParameters() != null ? tab.getParameters() : new HashMap<>()
in which case we will overwrite only column_stats properties and preserve the rest (if there were any).
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 6536)
<https://reviews.apache.org/r/49052/#comment204228>
getInputs(), getOutputs()
- Ashutosh Chauhan
On June 21, 2016, 11:41 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49052/
> -----------------------------------------------------------
>
> (Updated June 21, 2016, 11:41 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14028
>
>
> Diffs
> -----
>
> hbase-handler/src/test/queries/positive/hbasestats.q PRE-CREATION
> hbase-handler/src/test/results/positive/hbasestats.q.out PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 774cc2b
>
> Diff: https://reviews.apache.org/r/49052/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 49052: Insert overwrite does not work in HBase
tables: stats is not updated
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49052/
-----------------------------------------------------------
(Updated June 22, 2016, 8:14 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
HIVE-14028
Diffs (updated)
-----
hbase-handler/src/test/queries/positive/hbasestats.q PRE-CREATION
hbase-handler/src/test/results/positive/hbase_queries.q.out a99f561
hbase-handler/src/test/results/positive/hbase_single_sourced_multi_insert.q.out 38c51b5
hbase-handler/src/test/results/positive/hbasestats.q.out PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 774cc2b
Diff: https://reviews.apache.org/r/49052/diff/
Testing
-------
Thanks,
pengcheng xiong