You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by rd...@apache.org on 2003/10/18 15:30:22 UTC
cvs commit: jakarta-commons/digester/src/test/org/apache/commons/digester/xmlrules DigesterLoaderTest.java
rdonkin 2003/10/18 06:30:22
Modified: digester/src/test/org/apache/commons/digester
BeanPropertySetterRuleTestCase.java
CallMethodRuleTestCase.java EBRTestCase.java
digester/src/test/org/apache/commons/digester/xmlrules
DigesterLoaderTest.java
Log:
Removed system.out's from tests. Patch submitted by Simon Kitching.
Revision Changes Path
1.13 +3 -4 jakarta-commons/digester/src/test/org/apache/commons/digester/BeanPropertySetterRuleTestCase.java
Index: BeanPropertySetterRuleTestCase.java
===================================================================
RCS file: /home/cvs/jakarta-commons/digester/src/test/org/apache/commons/digester/BeanPropertySetterRuleTestCase.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- BeanPropertySetterRuleTestCase.java 9 Oct 2003 21:09:48 -0000 1.12
+++ BeanPropertySetterRuleTestCase.java 18 Oct 2003 13:30:22 -0000 1.13
@@ -363,7 +363,6 @@
digester.parse(xmlTestReader());
fail("Should have thrown NoSuchMethodException");
} catch (Exception e) {
- e.printStackTrace(System.err);
if (e instanceof InvocationTargetException) {
Throwable t =
((InvocationTargetException) e).getTargetException();
1.12 +3 -5 jakarta-commons/digester/src/test/org/apache/commons/digester/CallMethodRuleTestCase.java
Index: CallMethodRuleTestCase.java
===================================================================
RCS file: /home/cvs/jakarta-commons/digester/src/test/org/apache/commons/digester/CallMethodRuleTestCase.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- CallMethodRuleTestCase.java 9 Oct 2003 21:09:48 -0000 1.11
+++ CallMethodRuleTestCase.java 18 Oct 2003 13:30:22 -0000 1.12
@@ -517,8 +517,6 @@
digester.push(list);
digester.parse(reader);
- System.out.println(list);
-
NamedBean bean = (NamedBean) list.get(0);
assertEquals("Wrong name (1)", "Simple", bean.getName());
// these are added in deepest first order by the addRootRule
1.11 +4 -5 jakarta-commons/digester/src/test/org/apache/commons/digester/EBRTestCase.java
Index: EBRTestCase.java
===================================================================
RCS file: /home/cvs/jakarta-commons/digester/src/test/org/apache/commons/digester/EBRTestCase.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- EBRTestCase.java 13 Oct 2003 20:52:21 -0000 1.10
+++ EBRTestCase.java 18 Oct 2003 13:30:22 -0000 1.11
@@ -444,7 +444,6 @@
list = digester.getRules().match(null, "b/b/c/e/d");
assertEquals("Wild ancester match (2)", 1, list.size());
assertEquals("Match missed (5)", "star-b-c-star" , ((TestRule) list.get(0)).getIdentifier());
- System.out.println("Finished ancester match.");
}
public void testLongMatch() {
1.16 +4 -5 jakarta-commons/digester/src/test/org/apache/commons/digester/xmlrules/DigesterLoaderTest.java
Index: DigesterLoaderTest.java
===================================================================
RCS file: /home/cvs/jakarta-commons/digester/src/test/org/apache/commons/digester/xmlrules/DigesterLoaderTest.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- DigesterLoaderTest.java 9 Oct 2003 21:09:50 -0000 1.15
+++ DigesterLoaderTest.java 18 Oct 2003 13:30:22 -0000 1.16
@@ -113,7 +113,6 @@
digester.push(new ArrayList());
Object root = digester.parse(input.openStream());
assertEquals("[foo1 baz1 foo2, foo3 foo4]",root.toString());
- //System.out.println(root);
}
/**
@@ -295,7 +294,7 @@
fail("Exception should have been propagated from create method.");
} catch (Exception e) {
/* What we expected */
- System.out.println(e.getClass().getName());
+ assertEquals(org.xml.sax.SAXParseException.class, e.getClass());
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org