You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/03/31 09:01:12 UTC

[GitHub] [netbeans] sdedic opened a new pull request #2847: [NETBEANS-5524] Check for priming action before use.

sdedic opened a new pull request #2847:
URL: https://github.com/apache/netbeans/pull/2847


   I changed the Accessory panel so that it enables the checkbox when there's NO action provider at all. In reality that does not happen with well-behaved projects, as they have at least Build or Run actions. But Ergonomics-proxies have no actions on them (at least they appeared so).
   Later, during open, the `getSupportedActions()` check is done again, to see whether the project really supports the action. Seemed to be working fine for PHP (and Maven, Ant, Gradle) on my clean setup.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi merged pull request #2847: [NETBEANS-5524] Check for priming action before use.

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2847:
URL: https://github.com/apache/netbeans/pull/2847


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2847: [NETBEANS-5524] Check for priming action before use.

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2847:
URL: https://github.com/apache/netbeans/pull/2847#issuecomment-811403265


   I tested this fix and opening PHP project works.
   Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2847: [NETBEANS-5524] Check for priming action before use.

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2847:
URL: https://github.com/apache/netbeans/pull/2847#discussion_r604939988



##########
File path: ide/projectui/src/org/netbeans/modules/project/ui/ProjectChooserAccessory.java
##########
@@ -346,7 +347,12 @@ private static int countPrimable(Iterable<Project> projects) {
         for (Project p : projects) {
             final Lookup lkp = p.getLookup();
             final ActionProvider ap = lkp.lookup(ActionProvider.class);
-            if (ap != null && ap.isActionEnabled(ActionProvider.COMMAND_PRIME, lkp)) {
+            if (ap == null) {
+                // a Project without any actions ? Most probably ergonomics-proxy, count it in!
+                cnt++;

Review comment:
       Wow, great idea!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists