[GitHub] [iceberg] rdblue commented on a change in pull request #3834: change delete logic

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3834:
URL: https://github.com/apache/iceberg/pull/3834#discussion_r790357223



##########
File path: core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java
##########
@@ -151,9 +146,14 @@ private void internalPosDelete(StructLike key) {
      * @param row the given row to delete.
      */
     public void delete(T row) throws IOException {
-      internalPosDelete(structProjection.wrap(asStructLike(row)));
+      StructProjection key = structProjection.wrap(asStructLike(row));
+      PathOffset previous = insertedRowMap.get(key);
 
-      eqDeleteWriter.write(row);
+      if (previous != null){

Review comment:
       Style: there should be a space between `)` and `{`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org