[jira] Commented: (CAY-1191) Undo/Redo support in modeler

["Andrey Razumovsky (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAY-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762301#action_12762301 ] 

Andrey Razumovsky commented on CAY-1191:
----------------------------------------

Anton,

Thanks for the patch. I'm committing it now so that others could play with undo/redo. Still, some of issues I pointed before still exist.

The most important thing is #7 - undo brings wrong field value (e.g. "abrtist" instead of "artist").
For #6, can we replace table undo labels simply to "Undo Cell Change". E.g. "Undo true" is quite confusing.

#4 is now much better, but can we also keep track of exact tab where changes were made? E.g. change DbEntity name -> move to attributes tab -> Undo should activate main DbEntity tab.

EntitySync undo doesn't work correctly. Most usable scenario here is add attribute to DbEntity -> Sync -> Undo.

SQLTemplate & EJBQL editors still lack undo functionality.

Please don't add serialVersionUID variables to serializable classes. This doesn't make any sense for us, only shades main code. I don't know of others, but at least Eclipse IDE can disable this type of warnings (this is what I do).

In the end I should say that we're almost there, generally Undo-Redo is cool and usable!

> Undo/Redo support in modeler
> ----------------------------
>
>                 Key: CAY-1191
>                 URL: https://issues.apache.org/jira/browse/CAY-1191
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>    Affects Versions: 3.0M5
>            Reporter: Andrey Razumovsky
>            Assignee: Andrey Razumovsky
>         Attachments: icon-redo.gif, icon-undo.gif, patch.txt, patch.txt, patch.txt
>
>
> Modeler should support Undo/Redo. History should include all add/remove/edit/sync operations and be reset after 'Major' operations like Reverse-Engineer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.