You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/11/08 06:46:16 UTC
Review Request 27772: Fix fails pass on SchedulerDriverServiceTest
case.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27772/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
I noticed this test was encountering an AssertionError, but passing anyway because the desired result was still matched:
`Exception: java.lang.AssertionError thrown from the UncaughtExceptionHandler in thread "SchedulerDriverService STARTING"`
Diffs
-----
src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java 11f59c96a3676bd1ed7843ba0b99e7b196a4c98c
Diff: https://reviews.apache.org/r/27772/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27772: Fix false passing test case in
SchedulerDriverServiceTest.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27772/#review60475
-----------------------------------------------------------
Ship it!
Master (54b0262) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Nov. 8, 2014, 5:53 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27772/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2014, 5:53 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I noticed this test was encountering an AssertionError, but passing anyway because the desired result was still matched:
>
> `Exception: java.lang.AssertionError thrown from the UncaughtExceptionHandler in thread "SchedulerDriverService STARTING"`
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java 11f59c96a3676bd1ed7843ba0b99e7b196a4c98c
>
> Diff: https://reviews.apache.org/r/27772/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27772: Fix false passing test case in
SchedulerDriverServiceTest.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27772/#review60639
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 7, 2014, 9:53 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27772/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 9:53 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I noticed this test was encountering an AssertionError, but passing anyway because the desired result was still matched:
>
> `Exception: java.lang.AssertionError thrown from the UncaughtExceptionHandler in thread "SchedulerDriverService STARTING"`
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java 11f59c96a3676bd1ed7843ba0b99e7b196a4c98c
>
> Diff: https://reviews.apache.org/r/27772/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27772: Fix false passing test case in
SchedulerDriverServiceTest.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27772/
-----------------------------------------------------------
(Updated Nov. 8, 2014, 5:53 a.m.)
Review request for Aurora and Kevin Sweeney.
Summary (updated)
-----------------
Fix false passing test case in SchedulerDriverServiceTest.
Repository: aurora
Description
-------
I noticed this test was encountering an AssertionError, but passing anyway because the desired result was still matched:
`Exception: java.lang.AssertionError thrown from the UncaughtExceptionHandler in thread "SchedulerDriverService STARTING"`
Diffs
-----
src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java 11f59c96a3676bd1ed7843ba0b99e7b196a4c98c
Diff: https://reviews.apache.org/r/27772/diff/
Testing
-------
Thanks,
Bill Farner