You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Robert Newson (JIRA)" <ji...@apache.org> on 2011/08/15 12:15:27 UTC
[jira] [Commented] (COUCHDB-1242) Filtered replication silently
converts all query parameters to strings
[ https://issues.apache.org/jira/browse/COUCHDB-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085014#comment-13085014 ]
Robert Newson commented on COUCHDB-1242:
----------------------------------------
For trunk this also needs to update the validate_doc_update fun for _replicator
> Filtered replication silently converts all query parameters to strings
> ----------------------------------------------------------------------
>
> Key: COUCHDB-1242
> URL: https://issues.apache.org/jira/browse/COUCHDB-1242
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.2, 1.1
> Reporter: Robert Newson
> Assignee: Robert Newson
> Attachments: 0001-throw-400-bad_request-if-any-query_params-value-is-n.patch
>
>
> All filtered query params are silently converted to strings. this causes tests for if (req.query.foo) to evaluate to true even for {"query_params":{"foo":false}} because "false" is true.
> No clean solution exists to fix this as _changes has a GET entry point and request parameters are untyped.
> Suggested fix is to scan the query_params in handle_replicate_req and throw a 400 Bad Request if any value is not a JSON string.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira