You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/10/07 16:53:54 UTC

[GitHub] brooklyn-server pull request #375: Tidy tests to always terminate Management...

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/375

    Tidy tests to always terminate ManagementContext

    If we leave the management context running, it will not be garbage collected (because its threads reference it, so it's not just about reachability from the test class). This memory leak causes our tests to get slower and slower on the jenkins build server.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server tests-close-ManagementContext

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/375.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #375
    
----
commit b053b67bb10d205b982fb00f08a498d288c19521
Author: Aled Sage <al...@gmail.com>
Date:   2016-10-05T14:45:24Z

    Tidy tests to always terminate ManagementContext

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #375: Tidy tests to always terminate Management...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/375


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #375: Tidy tests to always terminate ManagementContext

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/375
  
    This fix is important because our apache jenkins builds sometimes timeout (seemingly with it consuming a lot of memory, based on the GC activity).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #375: Tidy tests to always terminate ManagementContext

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/375
  
    @sjcorbett thanks for review, and for link to `ITestResult`. I'll take a look at some point (but not just now).
    
    As for test guidelines, agree it would be good to have some of those. I don't think we have much written up about that. For example, we don't document the super-classes that one can extend, or the existence of `RecordingSshTool` etc.
    
    Merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #375: Tidy tests to always terminate ManagementContext

Posted by sjcorbett <gi...@git.apache.org>.

Github user sjcorbett commented on the issue:

    https://github.com/apache/brooklyn-server/pull/375
  
    Looks good to me. Are there any new guidelines test writers should follow? If yes it would be helpful to record them in documentation or on the mailing list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---