You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Sean Cooper <se...@gmail.com> on 2011/10/31 18:13:24 UTC
Review Request: RAVE 10 - Comments patch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2641/
-----------------------------------------------------------
Review request for rave.
Summary
-------
Patch to enable users to comment on the widget detail page, including reading other's comments, updating comments, and deleting comments
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1195443
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1195443
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1195443
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1195443
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1195443
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1195443
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1195568
trunk/rave-components/rave-core/src/test/resources/test_data.sql 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaUserRepositoryTest.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/UserRepository.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaUserRepository.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/User.java 1195443
trunk/rave-components/rave-core/pom.xml 1195443
Diff: https://reviews.apache.org/r/2641/diff
Testing
-------
Thanks,
Sean
Re: Review Request: RAVE 10 - Comments patch
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2641/#review3019
-----------------------------------------------------------
Patch looks good to me. Thanks Sean to submit the patch. I will apply the patch now.
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetComment.java
<https://reviews.apache.org/r/2641/#comment6737>
Changed to TIMESTAMP
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetComment.java
<https://reviews.apache.org/r/2641/#comment6738>
Changed to TIMESTAMP
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetCommentTest.java
<https://reviews.apache.org/r/2641/#comment6735>
organized import
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaUserRepositoryTest.java
<https://reviews.apache.org/r/2641/#comment6739>
organized import
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java
<https://reviews.apache.org/r/2641/#comment6736>
organized import
- Raminder
On 2011-11-02 14:48:06, Sean Cooper wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2641/
> -----------------------------------------------------------
>
> (Updated 2011-11-02 14:48:06)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> Patch to enable users to comment on the widget detail page, including reading other's comments, updating comments, and deleting comments
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/User.java 1196609
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1196609
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetComment.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetCommentRepository.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetCommentRepository.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1196609
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetCommentService.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1196609
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1196609
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetCommentService.java PRE-CREATION
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetCommentTest.java PRE-CREATION
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1196609
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaUserRepositoryTest.java 1196609
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1196609
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetCommentServiceTest.java PRE-CREATION
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1196609
> trunk/rave-components/rave-core/src/test/resources/test_data.sql 1196609
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1196609
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1196609
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1196609
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1196609
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1196609
> trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1196609
> trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1196609
>
> Diff: https://reviews.apache.org/r/2641/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sean
>
>
Re: Review Request: RAVE 10 - Comments patch
Posted by Sean Cooper <se...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2641/
-----------------------------------------------------------
(Updated 2011-11-02 14:48:06.667989)
Review request for rave.
Changes
-------
Corrected issues as a result of corrupted .pom file
Summary
-------
Patch to enable users to comment on the widget detail page, including reading other's comments, updating comments, and deleting comments
Diffs (updated)
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/User.java 1196609
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1196609
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetComment.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetCommentRepository.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetCommentRepository.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1196609
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetCommentService.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1196609
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1196609
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetCommentService.java PRE-CREATION
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetCommentTest.java PRE-CREATION
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1196609
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaUserRepositoryTest.java 1196609
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1196609
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetCommentServiceTest.java PRE-CREATION
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1196609
trunk/rave-components/rave-core/src/test/resources/test_data.sql 1196609
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1196609
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1196609
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1196609
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1196609
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1196609
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1196609
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1196609
Diff: https://reviews.apache.org/r/2641/diff
Testing
-------
Thanks,
Sean
Re: Review Request: RAVE 10 - Comments patch
Posted by Sean Cooper <se...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2641/
-----------------------------------------------------------
(Updated 2011-11-01 18:27:07.583426)
Review request for rave.
Changes
-------
Updated to include 'new' classes which were missing from the original patch submission
Summary
-------
Patch to enable users to comment on the widget detail page, including reading other's comments, updating comments, and deleting comments
Diffs (updated)
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/UserRepository.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetCommentRepository.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaUserRepository.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetCommentRepository.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetCommentService.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetCommentService.java PRE-CREATION
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetCommentTest.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetComment.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/User.java 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaUserRepositoryTest.java 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/WidgetCommentRepositoryTest.java PRE-CREATION
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetCommentServiceTest.java PRE-CREATION
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1195568
trunk/rave-components/rave-core/src/test/resources/test_data.sql 1195443
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1195443
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1195443
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1195443
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1195443
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1195443
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1195443
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1195443
Diff: https://reviews.apache.org/r/2641/diff
Testing
-------
Thanks,
Sean
Re: Review Request: RAVE 10 - Comments patch
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2641/#review2983
-----------------------------------------------------------
New file WidgetComment is missing in the patch. Can you submit a new patch with that file
- Raminder
On 2011-10-31 17:21:58, Sean Cooper wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2641/
> -----------------------------------------------------------
>
> (Updated 2011-10-31 17:21:58)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> Patch to enable users to comment on the widget detail page, including reading other's comments, updating comments, and deleting comments
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1195443
> trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1195443
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1195443
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1195443
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1195443
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1195443
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1195443
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1195568
> trunk/rave-components/rave-core/src/test/resources/test_data.sql 1195443
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaUserRepositoryTest.java 1195443
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1195443
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1195443
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1195443
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1195443
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/UserRepository.java 1195443
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaUserRepository.java 1195443
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1195443
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/User.java 1195443
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1195443
>
> Diff: https://reviews.apache.org/r/2641/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sean
>
>
Re: Review Request: RAVE 10 - Comments patch
Posted by Sean Cooper <se...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2641/
-----------------------------------------------------------
(Updated 2011-10-31 17:21:58.112462)
Review request for rave.
Changes
-------
removed the accidental .pom update
Summary
-------
Patch to enable users to comment on the widget detail page, including reading other's comments, updating comments, and deleting comments
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1195443
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1195443
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1195443
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1195443
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1195443
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1195443
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1195568
trunk/rave-components/rave-core/src/test/resources/test_data.sql 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaUserRepositoryTest.java 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1195443
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/UserRepository.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaUserRepository.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/User.java 1195443
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1195443
Diff: https://reviews.apache.org/r/2641/diff
Testing
-------
Thanks,
Sean