You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/16 23:56:31 UTC
[GitHub] [tvm] areusch opened a new pull request, #12828: Fix caffe, boost install in Python venvs by creating python3.X link
areusch opened a new pull request, #12828:
URL: https://github.com/apache/tvm/pull/12828
This PR fixes some of the ongoing problems we're having building docker images after merging #12663 . It links `caffe` into the venv and ensures that cmake will find the venv Python by ensuring that the `python3.7` command resolves to the venv Python.
@leandron @driazati
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #12828: Fix caffe, boost install in Python venvs by creating python3.X link
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #12828:
URL: https://github.com/apache/tvm/pull/12828#discussion_r975601233
##########
docker/install/ubuntu_install_caffe.sh:
##########
@@ -65,5 +65,4 @@ cd / && rm -rf /caffe_src
PYCAFFE_ROOT=${CAFFE_HOME}/python
echo "${CAFFE_HOME}/lib" >> /etc/ld.so.conf.d/caffe.conf && ldconfig
-VENV_SITE_PACKAGE=$(pip3 show numpy | grep "Location:" | cut -d ' ' -f 2)
-ln -s ${PYCAFFE_ROOT}/caffe ${VENV_SITE_PACKAGE}/caffe
Review Comment:
true, do you have a preference? cc @ashutosh-arm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #12828: Fix caffe, boost install in Python venvs by creating python3.X link
Posted by GitBox <gi...@apache.org>.
areusch merged PR #12828:
URL: https://github.com/apache/tvm/pull/12828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #12828: Fix caffe, boost install in Python venvs by creating python3.X link
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12828:
URL: https://github.com/apache/tvm/pull/12828#issuecomment-1249943259
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end--><!--bot-comment-skipped-tests-start-->
* Unable to run tests bot because main failed to pass CI at 38f53e8c95d6b4387510e38da89b02edb913e886.<!--bot-comment-skipped-tests-end--><!--bot-comment-docs-start-->
* Built docs for commit 908c0e9e8a0a30bb2f75aa67ed25ab58557ad8ea can be found [here](https://pr-docs.tlcpack.ai/PR-12828/display/docs/index.html).<!--bot-comment-docs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #12828: Fix caffe, boost install in Python venvs by creating python3.X link
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12828:
URL: https://github.com/apache/tvm/pull/12828#discussion_r973511124
##########
docker/install/ubuntu_install_caffe.sh:
##########
@@ -65,5 +65,4 @@ cd / && rm -rf /caffe_src
PYCAFFE_ROOT=${CAFFE_HOME}/python
echo "${CAFFE_HOME}/lib" >> /etc/ld.so.conf.d/caffe.conf && ldconfig
-VENV_SITE_PACKAGE=$(pip3 show numpy | grep "Location:" | cut -d ' ' -f 2)
-ln -s ${PYCAFFE_ROOT}/caffe ${VENV_SITE_PACKAGE}/caffe
Review Comment:
fyi #12813 fixed this too via site-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #12828: Fix caffe, boost install in Python venvs by creating python3.X link
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #12828:
URL: https://github.com/apache/tvm/pull/12828#discussion_r975603252
##########
docker/install/ubuntu_install_caffe.sh:
##########
@@ -65,5 +65,4 @@ cd / && rm -rf /caffe_src
PYCAFFE_ROOT=${CAFFE_HOME}/python
echo "${CAFFE_HOME}/lib" >> /etc/ld.so.conf.d/caffe.conf && ldconfig
-VENV_SITE_PACKAGE=$(pip3 show numpy | grep "Location:" | cut -d ' ' -f 2)
-ln -s ${PYCAFFE_ROOT}/caffe ${VENV_SITE_PACKAGE}/caffe
Review Comment:
oh sorry, reading the CI failure now. ignore me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org