[jira] [Commented] (HIVE-13163) ORC MemoryManager thread checks are fatal, should WARN

["Prasanth Jayachandran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-13163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168366#comment-15168366 ] 

Prasanth Jayachandran commented on HIVE-13163:
----------------------------------------------

LGTM, +1

> ORC MemoryManager thread checks are fatal, should WARN 
> -------------------------------------------------------
>
>                 Key: HIVE-13163
>                 URL: https://issues.apache.org/jira/browse/HIVE-13163
>             Project: Hive
>          Issue Type: Bug
>          Components: ORC
>    Affects Versions: 2.0.0, 2.1.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>              Labels: PIG
>         Attachments: HIVE-13163.1.patch
>
>
> The MemoryManager is tied to a WriterOptions on create, which can occur in a different thread from the writer calls.
> This is unexpected, but safe and needs a warning not a fatal.
> {code}
>   /**
>    * Light weight thread-safety check for multi-threaded access patterns
>    */
>   private void checkOwner() {
>     Preconditions.checkArgument(ownerLock.isHeldByCurrentThread(),
>         "Owner thread expected %s, got %s",
>         ownerLock.getOwner(),
>         Thread.currentThread());
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)