You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/23 21:44:15 UTC
[GitHub] [arrow] viirya opened a new pull request, #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
viirya opened a new pull request, #13219:
URL: https://github.com/apache/arrow/pull/13219
arrow-rs has fixed severals integration test failures:
generate_decimal128_case
generate_interval_case
generate_map_case
generate_non_canonical_map_case
generate_nested_large_offsets_case
generate_nested_dictionary_case
generate_unions_case
And this one passes test without any fix:
generate_extension_case
We should activate these IPC integration tests for rust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1151582611
Amazing work @viirya ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] viirya commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1146337163
Yea, `FAILED TEST: decimal Rust producing, Rust consuming` was fixed now. Continuing looking into remaining two failed cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1151583578
The arrow repo used to have a different way of merging PRs (using a script) -- let me know if you would like to give it a try or if you would like me to. 🎖️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1135165516
:warning: Ticket **has no components in JIRA**, make sure you assign one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1135942612
This is epic -- thank you @viirya for looking into this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1135165525
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] viirya commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1146701134
For `FAILED TEST: union Rust producing, Rust consuming`, proposed the fix at https://github.com/apache/arrow-rs/pull/1789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] viirya commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1151578098
@alamb All tests are passed now. Please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] viirya commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1152960117
Thank you @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] viirya commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1135175310
cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] viirya commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1135232824
Hmm, I ran `archery integration --with-cpp=true --with-rust=true` locally without any issue. I'll look into the difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] viirya commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1141617526
Regarding the failure `FAILED TEST: decimal Rust producing, Rust consuming`, it is because Rust performs a decimal check that C++ doesn't. And in the golden file `0.14.1_decimal.gold.json`, there are some values failing this check. I can conform that the test can be passed if removing the check in Rust side.
I propose a quick fix at Rust side to remove it, just following C++ Arrow decimal builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1152896191
Following the process in https://github.com/apache/arrow/tree/master/dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1152896737
Thanks again @viirya -- this is a major step forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] viirya commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1151593037
@alamb Thank you. I think you can just merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1152895907
Looking into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb merged pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
alamb merged PR #13219:
URL: https://github.com/apache/arrow/pull/13219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1135165497
https://issues.apache.org/jira/browse/ARROW-16636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] viirya commented on pull request #13219: ARROW-16636: [Rust] Activate several IPC integration tests for rust
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #13219:
URL: https://github.com/apache/arrow/pull/13219#issuecomment-1140183598
I'm in business trip this week. I will have more time to look into this in next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org