[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling
URL: https://github.com/apache/spark/pull/24613#discussion_r284386063
 
 

 ##########
 File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchStream.scala
 ##########
 @@ -73,6 +74,11 @@ private[kafka010] class KafkaMicroBatchStream(
 
   private var endPartitionOffsets: KafkaSourceOffset = _
 
+  private lazy val offsetMetrics = new KafkaCommitsSource()
+
+  private val shouldSetCommitOffsetsOnCheckpoints =
+    Option(options.get("setCommitOffsetsOnCheckpoints")).exists(_.toBoolean)
 
 Review comment:
   Hi @skonto . 
   Could you add some test coverage for this new option, please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org