[GitHub] [incubator-doris] imay commented on a change in pull request #1614: Fix bug: localtime is not thread-safe, then changed to localtime_r.

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1614: Fix bug: localtime is not thread-safe,then changed to localtime_r.
URL: https://github.com/apache/incubator-doris/pull/1614#discussion_r312002929
 
 

 ##########
 File path: be/src/exec/base_scanner.cpp
 ##########
 @@ -144,12 +145,21 @@ bool BaseScanner::fill_dest_tuple(const Slice& line, Tuple* dest_tuple, MemPool*
         ExprContext* ctx = _dest_expr_ctx[dest_index];
         void* value = ctx->get_value(_src_tuple_row);
         if (value == nullptr) {
-            if (_strict_mode && (_src_slot_descs_order_by_dest[dest_index] != nullptr)
-                && !_src_tuple->is_null(_src_slot_descs_order_by_dest[dest_index]->null_indicator_offset())) {
+            SlotDescriptor* slotDescriptor = _src_slot_descs_order_by_dest[dest_index];
 
 Review comment:
   ```suggestion
               SlotDescriptor* slot_descriptor = _src_slot_descs_order_by_dest[dest_index];
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org