You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/10/26 00:34:30 UTC

[GitHub] john-bodley opened a new pull request #6195: [datasource] Update SQL Lab exploration

john-bodley opened a new pull request #6195: [datasource] Update SQL Lab exploration
URL: https://github.com/apache/incubator-superset/pull/6195
 
 
   This PR updates the exploration of a datasource in SQL Lab to ensure that the link opens in a new tab as it seems more intuitive that users would want to continue exploring. I also updated the tooltip to better reflect the action. 
   
   Note that for Superset views the SQL Lab query in incorrect, i.e., it should contain the SQL associated with the view as opposed to `SELECT * FROM <view> LIMIT 100`. 
   
   <img width="262" alt="screen shot 2018-10-25 at 5 28 46 pm" src="https://user-images.githubusercontent.com/4567245/47537698-3023d880-d87c-11e8-9d55-35557e8762d5.png">
   
   to: @graceguo-supercat @kristw @mistercrunch   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org