[GitHub] [httpd] notroj commented on a change in pull request #280: Tweak FLUSH handling in mod_deflate input filter

[GitBox <gi...@apache.org>]

notroj commented on a change in pull request #280:
URL: https://github.com/apache/httpd/pull/280#discussion_r761916842



##########
File path: modules/filters/mod_deflate.c
##########
@@ -1313,9 +1314,7 @@ static apr_status_t deflate_in_filter(ap_filter_t *f,
                 break;
             }
 
-            if (APR_BUCKET_IS_FLUSH(bkt)) {
-                apr_bucket *tmp_b;
-
+            if (APR_BUCKET_IS_FLUSH(bkt) && !ctx->done) {

Review comment:
       Thanks!  Yes, I was playing around with some other changes and ended up with this... makes much more sense that way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org