You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/03 22:58:55 UTC
[GitHub] [airflow] steveyz-astro opened a new pull request #21981: If uploading task logs to S3 fails, retry once
steveyz-astro opened a new pull request #21981:
URL: https://github.com/apache/airflow/pull/21981
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #21981: If uploading task logs to S3 fails, retry once
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #21981:
URL: https://github.com/apache/airflow/pull/21981#issuecomment-1058878870
I’m not sure this is a good enough solution to be included in the default implementation. Why do I have to retry, and why only exactly once?
A better implementation may be to add a `retry: int` argument to the operator, and retry that many times (default is 0) with a loop instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21981: If uploading task logs to S3 fails, retry once
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21981:
URL: https://github.com/apache/airflow/pull/21981#issuecomment-1061234824
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21981: If uploading task logs to S3 fails, retry once
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21981:
URL: https://github.com/apache/airflow/pull/21981#issuecomment-1061234694
@uranusjr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #21981: If uploading task logs to S3 fails, retry once
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #21981:
URL: https://github.com/apache/airflow/pull/21981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21981: If uploading task logs to S3 fails, retry once
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21981:
URL: https://github.com/apache/airflow/pull/21981#issuecomment-1060105013
> generally the marginal benefit will be for a single retry. s3 oneshot uploads fail randomly very occasionally but failures do happen. Consecutive failures generally indicate a non-ephemeral condition. A single retry would resolve the 90-99% use case with minimal complexity. Multiple retries wouldn't provide much additional benefit.
>
> what do you think of parametrizing with a conf setting similar to `encrypt=conf.getboolean('logging',` 'ENCRYPT_S3_LOGS')` ?
The less options the better. I think It's fine to be hard-coded as a value. The explanation above is good enough but it should find its way to the comment in the code explaining why we try only twice. And even it it is 2, I agree with @uranusjr this is not the best way - it will be less duplication and even less complex if it is in a while or for loop rather than try/except with twice the same code. It's far too easy to miss the second one if we decide to add a new parameter to the call (label for example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] steveyz-astro commented on pull request #21981: If uploading task logs to S3 fails, retry once
Posted by GitBox <gi...@apache.org>.
steveyz-astro commented on pull request #21981:
URL: https://github.com/apache/airflow/pull/21981#issuecomment-1059352470
@uranusjr
generally the marginal benefit will be for a single retry. s3 oneshot uploads fail randomly very occasionally but failures do happen. Consecutive failures generally indicate a non-ephemeral condition. A single retry would resolve the 90-99% use case with minimal complexity. Multiple retries wouldn't provide much additional benefit.
what do you think of parametrizing with a conf setting similar to `encrypt=conf.getboolean('logging',` 'ENCRYPT_S3_LOGS')` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org