You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/12/04 02:53:07 UTC

[kudu-CR] [txn] update not-a-leader retry logic in TxnSystemClient

Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16815

to look at the new patch set (#2).

Change subject: [txn] update not-a-leader retry logic in TxnSystemClient
......................................................................

[txn] update not-a-leader retry logic in TxnSystemClient

This patch updates the retry logic in TxnSystemClient to handle
the case when TxnStatusManager returns Status::ServiceUnavailable().

In addition, this patch adds extra provision to check for tablet replica
status in StatusManager::CheckTxnStatusDataLoadedUnlocked().
The signatures of the involved methods have been updated as well.

This patch also enhances FinalizeCommitTransaction() to report
on errors from underlying tablet, if any.

I didn't add new tests scenarios in this patch: they are present in
follow-up patches which introduce the tracking of staled transactions.

Change-Id: I1b8abb27c7678c5c616a325343620902f6cbfd59
---
M src/kudu/client/client-test.cc
M src/kudu/tablet/txn_coordinator.h
M src/kudu/transactions/coordinator_rpc.cc
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
M src/kudu/tserver/tablet_service.cc
7 files changed, 148 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/16815/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16815
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1b8abb27c7678c5c616a325343620902f6cbfd59
Gerrit-Change-Number: 16815
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)