[jira] [Commented] (KAFKA-161) Producer using broker list does not load balance requests across multiple partitions on a broker

["Jun Rao (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131900#comment-13131900 ] 

Jun Rao commented on KAFKA-161:
-------------------------------

1. We should guard logger.debug with the isDebugEnabled check.
2. The method name getNumPartitionsForTopic is misleading since the return value is a list of partitions, instead of number of partitions. Can we rename it to sth like getPartitionListForTopic? Ditto for the name of the variable being assigned to.

                
> Producer using broker list does not load balance requests across multiple partitions on a broker
> ------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-161
>                 URL: https://issues.apache.org/jira/browse/KAFKA-161
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.7
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>             Fix For: 0.7
>
>         Attachments: KAFKA-161.patch
>
>
> https://issues.apache.org/jira/browse/KAFKA-129 introduced a bug in the load balancing logic of the Producer using broker.list.
> Since the broker.list doesn't specify the number of partitions in total, it should ideally pick a broker randomly, and then send the produce request with partition id -1, so that the EventHandler routes the request to a random partition.
> Instead of that, it defaults to 1 partition on each broker and ends up using the Partitioner to pick a partitions amongst the available ones.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira