You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/23 07:01:19 UTC

[GitHub] [phoenix] stoty opened a new pull request #841: PHOENIX-6028 Change default HBase profile to 2.1 in 5.x

stoty opened a new pull request #841:
URL: https://github.com/apache/phoenix/pull/841


   * change default HBase profile
   * bump the default HBase version to 2.2.5 for the 2.2 profile
   * update BUILDING.md and add instuctions for PHOENIX-5593


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] stoty closed pull request #841: PHOENIX-6028 Change default HBase profile to 2.1 in 5.x

Posted by GitBox <gi...@apache.org>.
stoty closed pull request #841:
URL: https://github.com/apache/phoenix/pull/841


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] stoty commented on a change in pull request #841: PHOENIX-6028 Change default HBase profile to 2.1 in 5.x

Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #841:
URL: https://github.com/apache/phoenix/pull/841#discussion_r463051783



##########
File path: dev/rebuild_hbase.sh
##########
@@ -0,0 +1,16 @@
+#!/bin/sh
+# Downloads the specified HBase version sources into PWD, extracts it, 
+# then rebuilds and installs the artifacts with -Dhadoop.profile=3.0
+
+if [ $# -ne 1 ]
+  then
+    echo "Supply the Hbase version as paramater i.e.: rebuild_hbase.sh 2.2.6 "
+fi
+
+wget https://downloads.apache.org/hbase/$1/hbase-$1-src.tar.gz

Review comment:
       Sure, I will do that before commit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] joshelser commented on a change in pull request #841: PHOENIX-6028 Change default HBase profile to 2.1 in 5.x

Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #841:
URL: https://github.com/apache/phoenix/pull/841#discussion_r463023583



##########
File path: dev/rebuild_hbase.sh
##########
@@ -0,0 +1,16 @@
+#!/bin/sh
+# Downloads the specified HBase version sources into PWD, extracts it, 
+# then rebuilds and installs the artifacts with -Dhadoop.profile=3.0
+
+if [ $# -ne 1 ]
+  then
+    echo "Supply the Hbase version as paramater i.e.: rebuild_hbase.sh 2.2.6 "
+fi
+
+wget https://downloads.apache.org/hbase/$1/hbase-$1-src.tar.gz

Review comment:
       Infra requests that downloads.a.o/archive.a.o is only used for downloading KEYS, checksums, and signatures.
   
   Can you adapt the solution I have in https://github.com/apache/phoenix-queryserver/blob/master/python-phoenixdb/dev-support/cache-apache-project-artifact.sh to this script as well, please?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] stoty closed pull request #841: PHOENIX-6028 Change default HBase profile to 2.1 in 5.x

Posted by GitBox <gi...@apache.org>.
stoty closed pull request #841:
URL: https://github.com/apache/phoenix/pull/841


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org