[jira] [Commented] (SOLR-12360) ImplicitSnitchTest.testGetTags_with_wrong_ipv4_format_ip_returns_nothing sometimes fails

["Dawid Weiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594703#comment-16594703 ] 

Dawid Weiss commented on SOLR-12360:
------------------------------------

I still can't get this test to pass (and I don't want to change the default DNS on that build machine). Since this is failing in tests on real machines, I'm guessing it can also happen in the real world. The matcher selecting the host name/ ip address in ImplicitSnitchTest is very broad. We could restrict it, but this could have unexpected side-effects for people with funky hostnames. 

I'd rather just remove this particular test (testGetTags_with_wrong_ipv4_format_ip_returns_nothing). I didn't check whether dns with numbers only are valid (perhaps not at the global scale, but locally, within a nat network?), but if it's not explicitly forbidden then this test is checking a too strict assumption.

> ImplicitSnitchTest.testGetTags_with_wrong_ipv4_format_ip_returns_nothing sometimes fails
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-12360
>                 URL: https://issues.apache.org/jira/browse/SOLR-12360
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: Tomás Fernández Löbbe
>            Priority: Minor
>
> {noformat}
>    [junit4]    > Throwable #1: java.lang.AssertionError:
>    [junit4]    > Expected: is <0>
>    [junit4]    >      got: <1>
>    [junit4]    >        at
> org.apache.solr.cloud.rule.ImplicitSnitchTest.testGetTags_with_wrong_ipv4_format_ip_returns_nothing(ImplicitSnitchTest.java:104)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org