You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2024/02/09 09:45:44 UTC
[I] Experiment: New DRL parser : Better implementation switch [incubator-kie-drools]
tkobayas opened a new issue, #5683:
URL: https://github.com/apache/incubator-kie-drools/issues/5683
**Parent issue:** https://github.com/apache/incubator-kie-drools/issues/5678
https://github.com/apache/incubator-kie-drools/pull/5677#discussion_r1484046003
> @mariofusco @yurloc Do you think it's fine to call the new parser `DRL10`? This doesn't introduce a new syntax, but we need a clear separation. So I use `LanguageLevelOption`. Feel free to share your thoughts.
> Temporarily, yes. But it should be removed in the final step in my opinion.
> 1. The language level stays the same. We're just changing an implementation detail that deals with how the source code in DRL6 language is being parsed.
> 2. Is the language level option a public API? If yes, it's one more reason not to introduce DRL10. Implementation details should not proliferate to the public API.
Finally, we would like to use a better way for the implementation switch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser : Better implementation switch [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas closed issue #5683: Experiment: New DRL parser : Better implementation switch
URL: https://github.com/apache/incubator-kie-drools/issues/5683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser : Better implementation switch [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5683:
URL: https://github.com/apache/incubator-kie-drools/issues/5683#issuecomment-1953698950
Done by https://github.com/apache/incubator-kie-drools/pull/5693
Now we use system property switch `drools.drl.antlr4.parser.enabled` (`true` by default). No longer use `DRL10`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org