You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/10 01:27:35 UTC
[GitHub] [apisix] sasakiyori commented on a diff in pull request #7222: fix: remove deprecated upstream.enable_websocket
sasakiyori commented on code in PR #7222:
URL: https://github.com/apache/apisix/pull/7222#discussion_r894081939
##########
apisix/init.lua:
##########
@@ -486,9 +486,6 @@ function _M.http_access_phase()
end
local route_val = route.value
- if route_val.upstream and route_val.upstream.enable_websocket then
Review Comment:
I check the code and find there are no test cases and docs related with `upstream.enable_websocket`, only `route` and `service` related exists.
This field may be just missed by previous pr which removes deprecated features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org