You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/05/24 11:09:50 UTC
[GitHub] [cordova-docs] erisu commented on a change in pull request #997:
Update Electron Docs
erisu commented on a change in pull request #997: Update Electron Docs
URL: https://github.com/apache/cordova-docs/pull/997#discussion_r287315969
##########
File path: www/docs/en/9.x/guide/platforms/electron/index.md
##########
@@ -248,77 +254,75 @@ The `package` property is an array list of packages to be outputted. If the prop
The configuration example below will generate `tar.gz`, `dmg` and `zip` packages for macOS.
-```
+```json
{
- "electron": {
- "mac": {
- "package": [
- "dmg",
- "tar.gz",
- "zip"
- ]
+ "electron": {
+ "mac": {
+ "package": [
+ "dmg",
+ "tar.gz",
+ "zip"
+ ]
+ }
}
- }
}
```
**Available Packages by Operating System**
-| Package Type | Linux | macOS | Windows |
-| ------------ | :----------------: | :----------------: | :-----------------------------------: |
-| default | - | `dmg`<br />`zip` | - |
-| dmg | - | ✔ | - |
-| mas | - | ✔ | - |
-| mas-dev | ✔ | - | - |
-| pkg | - | ✔ | - |
-| 7z | ✔ | ✔ | ✔ |
-| zip | ✔ | ✔ | ✔ |
-| tar.xz | ✔ | ✔ | ✔ |
-| tar.lz | ✔ | ✔ | ✔ |
-| tar.gz | ✔ | ✔ | ✔ |
-| tar.bz2 | ✔ | ✔ | ✔ |
-| dir | ✔ | ✔ | ✔ |
-| nsis | - | - | ✔ |
-| nsis-web | - | - | ✔ |
-| portable | - | - | ✔ |
-| appx | - | - | ✔ <sup>**[1]**</sup> |
-| msi | - | - | ✔ |
-| AppImage | ✔ | - | - |
-| snap | ✔ | - | - |
-| deb | ✔ | - | - |
-| rpm | ✔ | - | - |
-| freebsd | ✔ | - | - |
-| pacman | ✔ | - | - |
-| p5p | ✔ | - | - |
-| apk | ✔ | - | - |
-
-* **[1]** Only Window 10 can build AppX packages.
-
-#### Setting the package `arch`
+| Package Type | Linux | macOS | Windows |
+| ------------ | :-----: | :--------------: | :------------------------: |
+| default | - | `dmg`<br />`zip` | - |
+| dmg | - | ✅ | - |
+| mas | - | ✅ | - |
+| mas-dev | ✅ | - | - |
Review comment:
The content should be exactly identical with the exceptions of:
- The table of contents does not exist here.
- The section "Customizing the Application's Icon" does not exist in the Electron section. All the icon related docs for all platforms are pulled into another file, sadly...
The original changes were made in this PR https://github.com/apache/cordova-electron/pull/61 and then copied to `cordova-docs/dev` and then snapshotted for `9.x`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org