You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "carloea2 (via GitHub)" <gi...@apache.org> on 2026/05/03 04:35:49 UTC
[PR] Backup/feat UI parameter e50e29260 [texera]
carloea2 opened a new pull request, #4843:
URL: https://github.com/apache/texera/pull/4843
### What changes were proposed in this PR?
This is PR 2 of the UiParameter split stack, based on PR 1.
This PR adds Scala-side infrastructure for injecting UI parameter values into Python UDF code, but does not activate it in execution yet.
It includes:
- `PythonUdfUiParameterInjector`.
- Validation for missing attributes, conflicting duplicate names, reserved hook collisions, and unsupported binary parameter types.
- Scala tests for injection behavior.
- String encoding support for parameter attribute names.
Execution remains unchanged in this PR: Python UDF descriptors still call `OpExecWithCode(code, "python")`.
```mermaid
sequenceDiagram
autonumber
participant Desc as Scala UDF Descriptor
participant Params as uiParameters Metadata
participant Injector as PythonUdfUiParameterInjector
participant Tests as Injector Specs
participant Exec as Existing Execution Path
Desc->>Params: Holds inert uiParameters
Tests->>Injector: Validate injection behavior
Injector->>Injector: Validate names, types, reserved hook
Injector->>Injector: Generate hook code when called
Desc->>Exec: Still executes original code
Note over Desc,Exec: Injector exists but is not wired into runtime yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(udf): add Scala UiParameter injection support [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4843:
URL: https://github.com/apache/texera/pull/4843#issuecomment-4365501579
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/4843?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 42.96%. Comparing base ([`1c3ec67`](https://app.codecov.io/gh/apache/texera/commit/1c3ec67977406fc1340d0f8e90d720ff71e7ae69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`cbafe34`](https://app.codecov.io/gh/apache/texera/commit/cbafe34a936322e72f9eb387d24e0242abc327af?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #4843 +/- ##
============================================
- Coverage 42.97% 42.96% -0.01%
Complexity 2029 2029
============================================
Files 957 957
Lines 34077 34064 -13
Branches 3753 3753
============================================
- Hits 14645 14637 -8
+ Misses 18655 18650 -5
Partials 777 777
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/4843/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [config-service](https://app.codecov.io/gh/apache/texera/pull/4843/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/4843?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(udf): add Scala UiParameter injection support [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #4843:
URL: https://github.com/apache/texera/pull/4843#issuecomment-4365521416
This PR is not going to be merged before the first, so when first is merged it will be reduced. In fact I will close this 2nd and 3rd after approval in the split strategy. And raise the PRs sequentially.
I just want to know if @kunwp1 like this split.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(udf): add Scala UiParameter injection support [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 closed pull request #4843: feat(udf): add Scala UiParameter injection support
URL: https://github.com/apache/texera/pull/4843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(udf): add Scala UiParameter injection support [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #4843:
URL: https://github.com/apache/texera/pull/4843#issuecomment-4365402194
@kunwp1 please confirm if this layout is ok for you to review. Then I can test it locally and request your review once it is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(udf): add Scala UiParameter injection support [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #4843:
URL: https://github.com/apache/texera/pull/4843#issuecomment-4365500500
It has 25 files. Can we divide it?
Check a related discussion about how to manage PRs https://github.com/apache/texera/discussions/4590 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org