You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andres de la Peña (Jira)" <ji...@apache.org> on 2021/08/20 10:37:00 UTC

[jira] [Commented] (CASSANDRA-16871) Add resource flags to CircleCi config generation script

    [ https://issues.apache.org/jira/browse/CASSANDRA-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402143#comment-17402143 ] 

Andres de la Peña commented on CASSANDRA-16871:
-----------------------------------------------

[Here|https://github.com/adelapena/cassandra/commit/3f45b0e00e7ef5027c06db9936773b701ec57435] is a draft of the script with {{-l}}/{{-m}}/{{-h}} flags.

> Add resource flags to CircleCi config generation script
> -------------------------------------------------------
>
>                 Key: CASSANDRA-16871
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16871
>             Project: Cassandra
>          Issue Type: Task
>            Reporter: Andres de la Peña
>            Assignee: Andres de la Peña
>            Priority: Normal
>
> Currently we have three versions of the CircleCI config file using different resources. Changing the resources configuration is as easy as copying the desired template file, for example:
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> {code}
> If we want to make changes to the file, for example to set a specific dtest repo or running the test multiplexer, we can run the provided generation script, copy the template file and probably exclude the additional changes:
> {code}
> # edit config-2_1.yml
> .circleci/generate.sh
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # undo the changes in config.yml.LOWRES, config.yml.MIDRES and config.yml.HIGHRES
> {code}
> A very common alternative to this is just editing the environment variables in the automatically generated {{config.yml}} file, which are repeated some 19 times across the file:
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # edit config.yml, where env vars are repeated
> {code}
> I think we could do this slightly easier by adding a set of flags to the generation script to apply the resources patch directly to {{config.yml}}, without changing the templates:
> {code}
> # edit config-2_1.yml
> .circleci/generate.sh -m
> {code}
> This has the advantage of not requiring manually editing the automatically generated file and also providing some validation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org