You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/15 15:51:12 UTC
[GitHub] [incubator-doris] xiaokang opened a new pull request, #10169: optimize substr performance
xiaokang opened a new pull request, #10169:
URL: https://github.com/apache/incubator-doris/pull/10169
# Proposed changes
optimize substr performance about 1.5~2x speedup.
## Problem Summary:
Describe the overview of changes.
1. use volnitsky string search algorithm instead of std::search
2. use long run length searching for a big string instead of search for each string
## Checklist(Required)
1. Does it affect the original behavior: (No)
3. Has unit tests been added: (No Need)
4. Has document been added or modified: (No Need)
5. Does it need to update dependencies: (No)
6. Are there any changes that cannot be rolled back: (No)
## Further comments
Thanks to clickhouse community, the optimization idea and volnitsky.h string_searcher.h code is from clickhouse.
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10169:
URL: https://github.com/apache/doris/pull/10169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
xiaokang commented on PR #10169:
URL: https://github.com/apache/doris/pull/10169#issuecomment-1159990261
Here are some detailed explanation for the test.
**test env**
- test data: 25GB text log, 110 million rows
- test table: test_table(ts varchar(30), log string)
- test SQL 1: select count() from belog_lz4fix where log like '%minidump%'; the result is 1
- test SQL 2: select count() from belog_lz4fix where log like '%vaggregation\_node.cpp%'; the result is 1201154
- be.conf: disable_storage_page_cache = true
set this config to disable doris page cache to avoid all data cached in memory for test real decompression speed.
test result
**test result**
- No.1 : the original version, using std::search, std::default_searcher algorithm and calling search once for each single row
- No.2,3,4: change search algorithm to std::boyer_moore_searcher, std::boyer_moore_horspool_searcher, volnitsky respectively.
- No.5,6,7,8: corresponding to 1,2,3,4, change to call search across multi rows. It leverages the continuous memory layout of string column and benefits from long run length miss match.
**analysis**
- compare No.4 with No.1: replacing std::search with volnitsky get 1.51x speedup.
- compare No.5 with No.1: replacing search single row with search across rows for std::search, get 1.25x speedup.
- compare No.8 with No.4: replacing search single row with search across rows for volnitsky, the speedup grows from 1.51x to 2.04x.
- compare No.2,3 with No.1, No.6,7 with 5: there are little difference between std::default_searcher, std::boyer_moore_searcher, std::boyer_moore_horspool_searcher.
- compare the two SQL: the more miss match (or less match), the more speedup
**conclusion**
For the test data and test case:
1. volnitsky algrithm with search across rows is the best.
2. std::boyer_moore_horspool_searcher is better than std::default_searcher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xiaokang commented on pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
xiaokang commented on PR #10169:
URL: https://github.com/apache/incubator-doris/pull/10169#issuecomment-1158399123
> Hi, `std::search` has much better performance than gcc in clang, I wonder if `volnitsky` will be better than `std::search` in clang?
important information. I will do some comparison test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on a diff in pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
xiaokang commented on code in PR #10169:
URL: https://github.com/apache/doris/pull/10169#discussion_r905018251
##########
be/src/vec/functions/like.cpp:
##########
@@ -129,6 +130,42 @@ Status FunctionLikeBase::vector_vector(const ColumnString::Chars& values,
const ColumnString::Offsets& pattern_offsets,
ColumnUInt8::Container& result, const LikeFn& function,
LikeSearchState* search_state) {
+ // for constant_substring_fn, use long run length search for performance
+ if (constant_substring_fn ==
+ *(function.target<doris::Status (*)(LikeSearchState * state, const StringValue&,
+ const StringValue&, unsigned char*)>())) {
+ // treat continous multi string data as a long string data
+ const UInt8* begin = values.data();
+ const UInt8* end = begin + values.size();
+ const UInt8* pos = begin;
+
+ /// Current index in the array of strings.
+ size_t i = 0;
+ size_t needle_size = search_state->substring_pattern.get_pattern_length();
+
+ /// We will search for the next occurrence in all strings at once.
+ while (pos < end) {
+ // search return matched substring start offset
+ pos = (UInt8*)search_state->substring_pattern.search((char*)pos, end - pos);
+ if (pos >= end) break;
+
+ /// Determine which index it refers to.
+ /// begin + value_offsets[i] is the start offset of string at i+1
+ while (begin + value_offsets[i] <= pos) ++i;
+
+ /// We check that the entry does not pass through the boundaries of strings.
Review Comment:
OK. thanks for you careful review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on a diff in pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
xiaokang commented on code in PR #10169:
URL: https://github.com/apache/doris/pull/10169#discussion_r904424703
##########
be/src/vec/functions/like.cpp:
##########
@@ -129,6 +130,42 @@ Status FunctionLikeBase::vector_vector(const ColumnString::Chars& values,
const ColumnString::Offsets& pattern_offsets,
ColumnUInt8::Container& result, const LikeFn& function,
LikeSearchState* search_state) {
+ // for constant_substring_fn, use long run length search for performance
+ if (constant_substring_fn ==
+ *(function.target<doris::Status (*)(LikeSearchState * state, const StringValue&,
+ const StringValue&, unsigned char*)>())) {
+ // treat continous multi string data as a long string data
+ const UInt8* begin = values.data();
+ const UInt8* end = begin + values.size();
+ const UInt8* pos = begin;
+
+ /// Current index in the array of strings.
+ size_t i = 0;
+ size_t needle_size = search_state->substring_pattern.get_pattern_length();
+
+ /// We will search for the next occurrence in all strings at once.
+ while (pos < end) {
+ // search return matched substring start offset
+ pos = (UInt8*)search_state->substring_pattern.search((char*)pos, end - pos);
+ if (pos >= end) break;
+
+ /// Determine which index it refers to.
+ /// begin + value_offsets[i] is the start offset of string at i+1
+ while (begin + value_offsets[i] <= pos) ++i;
+
+ /// We check that the entry does not pass through the boundaries of strings.
Review Comment:
It's necessary to check the boundary.
Here is an example:
pattern: "cdef"
row1: "abcd"
row2: "efgh"
values.data: "abcdefgh"
value_offsets: [4, 8]
values.data "abcdefgh" will match pattern "cdef" at pos 2. The end of matched substring is pos+needle_size == 6. It's beyond the end offset of row1, which is begin+value_offsets[0]. So due to the check 'if (pos + needle_size < begin + value_offsets[i])', we will not set result[i]=1 improperly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10169:
URL: https://github.com/apache/doris/pull/10169#issuecomment-1163872963
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on a diff in pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
xiaokang commented on code in PR #10169:
URL: https://github.com/apache/doris/pull/10169#discussion_r904431043
##########
be/src/vec/functions/like.cpp:
##########
@@ -129,6 +130,42 @@ Status FunctionLikeBase::vector_vector(const ColumnString::Chars& values,
const ColumnString::Offsets& pattern_offsets,
ColumnUInt8::Container& result, const LikeFn& function,
LikeSearchState* search_state) {
+ // for constant_substring_fn, use long run length search for performance
+ if (constant_substring_fn ==
Review Comment:
There are different functions vectorVector, vectorConstant, constantVector for FunctionsStringSearch in clickhouse.
There are some difference between FunctionsStringSearch in clickhouse and like in doris.
We have many constant functions in like, such as constant_equals_fn, constant_starts_with_fn, constant_ends_with_fn, constant_substring_fn. We still need to add this special branch for constant_substring_fn, since we need to do special optimization for substring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #10169:
URL: https://github.com/apache/doris/pull/10169#discussion_r904476530
##########
be/src/vec/functions/like.cpp:
##########
@@ -129,6 +130,42 @@ Status FunctionLikeBase::vector_vector(const ColumnString::Chars& values,
const ColumnString::Offsets& pattern_offsets,
ColumnUInt8::Container& result, const LikeFn& function,
LikeSearchState* search_state) {
+ // for constant_substring_fn, use long run length search for performance
+ if (constant_substring_fn ==
+ *(function.target<doris::Status (*)(LikeSearchState * state, const StringValue&,
+ const StringValue&, unsigned char*)>())) {
+ // treat continous multi string data as a long string data
+ const UInt8* begin = values.data();
+ const UInt8* end = begin + values.size();
+ const UInt8* pos = begin;
+
+ /// Current index in the array of strings.
+ size_t i = 0;
+ size_t needle_size = search_state->substring_pattern.get_pattern_length();
+
+ /// We will search for the next occurrence in all strings at once.
+ while (pos < end) {
+ // search return matched substring start offset
+ pos = (UInt8*)search_state->substring_pattern.search((char*)pos, end - pos);
+ if (pos >= end) break;
+
+ /// Determine which index it refers to.
+ /// begin + value_offsets[i] is the start offset of string at i+1
+ while (begin + value_offsets[i] <= pos) ++i;
+
+ /// We check that the entry does not pass through the boundaries of strings.
Review Comment:
`values.data` will be "abcd\0efgh" here.
But after my investigation, there may be `\0` in the input string, this check is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on a diff in pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
xiaokang commented on code in PR #10169:
URL: https://github.com/apache/doris/pull/10169#discussion_r904432000
##########
be/src/vec/common/string_searcher.h:
##########
@@ -0,0 +1,860 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Common/StringSearcher.h
+// and modified by Doris
+
+#pragma once
+
+#include <stdint.h>
+#include <string.h>
+
+#include <algorithm>
+#include <limits>
+#include <vector>
+
+#include "vec/common/string_utils/string_utils.h"
+
+#ifdef __SSE2__
+#include <emmintrin.h>
+#endif
+
+#ifdef __SSE4_1__
+#include <smmintrin.h>
+#endif
+
+namespace doris {
+
+// namespace ErrorCodes
+// {
+// extern const int BAD_ARGUMENTS;
+// }
+
+/** Variants for searching a substring in a string.
+ * In most cases, performance is less than Volnitsky (see Volnitsky.h).
+ */
+
+class StringSearcherBase {
+public:
+ bool force_fallback = false;
+#ifdef __SSE2__
+protected:
+ static constexpr auto n = sizeof(__m128i);
+ const int page_size = sysconf(_SC_PAGESIZE); //::getPageSize();
+
+ bool page_safe(const void* const ptr) const {
+ return ((page_size - 1) & reinterpret_cast<std::uintptr_t>(ptr)) <= page_size - n;
+ }
+#endif
+};
+
+/// Performs case-sensitive and case-insensitive search of UTF-8 strings
+template <bool CaseSensitive, bool ASCII>
+class StringSearcher;
+
+// comment out since it's not used in doris and UTF8 dependency is not easy to meet
Review Comment:
I keep them in case for possible further usage. If it's better to remove them, I will add a commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #10169:
URL: https://github.com/apache/doris/pull/10169#discussion_r902713424
##########
be/src/vec/functions/like.cpp:
##########
@@ -129,6 +130,42 @@ Status FunctionLikeBase::vector_vector(const ColumnString::Chars& values,
const ColumnString::Offsets& pattern_offsets,
ColumnUInt8::Container& result, const LikeFn& function,
LikeSearchState* search_state) {
+ // for constant_substring_fn, use long run length search for performance
+ if (constant_substring_fn ==
+ *(function.target<doris::Status (*)(LikeSearchState * state, const StringValue&,
+ const StringValue&, unsigned char*)>())) {
+ // treat continous multi string data as a long string data
+ const UInt8* begin = values.data();
+ const UInt8* end = begin + values.size();
+ const UInt8* pos = begin;
+
+ /// Current index in the array of strings.
+ size_t i = 0;
+ size_t needle_size = search_state->substring_pattern.get_pattern_length();
+
+ /// We will search for the next occurrence in all strings at once.
+ while (pos < end) {
+ // search return matched substring start offset
+ pos = (UInt8*)search_state->substring_pattern.search((char*)pos, end - pos);
+ if (pos >= end) break;
+
+ /// Determine which index it refers to.
+ /// begin + value_offsets[i] is the start offset of string at i+1
+ while (begin + value_offsets[i] <= pos) ++i;
+
+ /// We check that the entry does not pass through the boundaries of strings.
Review Comment:
Whether our `text` and `pattern` may contain `\0`?
If it is impossible to contain `\0`, then this check will be unnecessary
##########
be/src/vec/common/string_searcher.h:
##########
@@ -0,0 +1,860 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Common/StringSearcher.h
+// and modified by Doris
+
+#pragma once
+
+#include <stdint.h>
+#include <string.h>
+
+#include <algorithm>
+#include <limits>
+#include <vector>
+
+#include "vec/common/string_utils/string_utils.h"
+
+#ifdef __SSE2__
+#include <emmintrin.h>
+#endif
+
+#ifdef __SSE4_1__
+#include <smmintrin.h>
+#endif
+
+namespace doris {
+
+// namespace ErrorCodes
+// {
+// extern const int BAD_ARGUMENTS;
+// }
+
+/** Variants for searching a substring in a string.
+ * In most cases, performance is less than Volnitsky (see Volnitsky.h).
+ */
+
+class StringSearcherBase {
+public:
+ bool force_fallback = false;
+#ifdef __SSE2__
+protected:
+ static constexpr auto n = sizeof(__m128i);
+ const int page_size = sysconf(_SC_PAGESIZE); //::getPageSize();
+
+ bool page_safe(const void* const ptr) const {
+ return ((page_size - 1) & reinterpret_cast<std::uintptr_t>(ptr)) <= page_size - n;
+ }
+#endif
+};
+
+/// Performs case-sensitive and case-insensitive search of UTF-8 strings
+template <bool CaseSensitive, bool ASCII>
+class StringSearcher;
+
+// comment out since it's not used in doris and UTF8 dependency is not easy to meet
Review Comment:
Does we should keep those unused code?
##########
be/src/vec/functions/like.cpp:
##########
@@ -129,6 +130,42 @@ Status FunctionLikeBase::vector_vector(const ColumnString::Chars& values,
const ColumnString::Offsets& pattern_offsets,
ColumnUInt8::Container& result, const LikeFn& function,
LikeSearchState* search_state) {
+ // for constant_substring_fn, use long run length search for performance
+ if (constant_substring_fn ==
Review Comment:
Maybe we should move it to a function like named `vector_constant`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #10169:
URL: https://github.com/apache/incubator-doris/pull/10169#issuecomment-1157170182
Hi, `std::search` has much better performance than gcc in clang, I wonder if `volnitsky` will be better than `std::search` in clang?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
xiaokang commented on PR #10169:
URL: https://github.com/apache/doris/pull/10169#issuecomment-1159934807
I have done the performance comparison test. The test shows that:
1. volnitsky algorithm with searching across rows is the best, which is 2.0x and 1.5x faster than std::search in two test cases. And gcc
2. gcc-11.1.0 and clang-13.0.1 is almost the same, with little difference and is negligible since tested at different time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10169:
URL: https://github.com/apache/doris/pull/10169#issuecomment-1163872988
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on pull request #10169: optimize substr performance
Posted by GitBox <gi...@apache.org>.
xiaokang commented on PR #10169:
URL: https://github.com/apache/doris/pull/10169#issuecomment-1161687509
@BiteTheDDDDt is there more comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org