You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/14 08:56:18 UTC

[GitHub] [airflow] fllaca commented on a change in pull request #11511: Helm chart fixes in pod template

fllaca commented on a change in pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#discussion_r504513822



##########
File path: chart/tests/pod-template-file_test.yaml
##########
@@ -22,14 +22,17 @@ tests:
     asserts:
       - isKind:
           of: Pod
-      - equal:
+      - isNotNull:
           path: spec.containers[0].image
-          value: dummy_image

Review comment:
       I could find a way to assert that this value should be the default `defaultAirflowRepository` without hardcoding the test with `apache/airflow:1.10.12` (copying from values.yaml). If that hardcoded value in the assertion is fine, I can change the test back to `equal` assert.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org