You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/20 12:06:05 UTC
[GitHub] [tvm] Mousius opened a new pull request #10001: [CI] Fix Rust path and remove wasmtime from ci_qemu
Mousius opened a new pull request #10001:
URL: https://github.com/apache/tvm/pull/10001
This fixes the Rust path to ensure `cargo` is accessible in the
container.
As ci_qemu is targetted at microTVM it likely won't make use of wasmtime
as a dependency - it's used instead for the JS and WASM standalone applications as
far as I can see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #10001: [CI] Fix Rust path and remove wasmtime from ci_qemu
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #10001:
URL: https://github.com/apache/tvm/pull/10001#discussion_r789108968
##########
File path: docker/Dockerfile.ci_qemu
##########
@@ -42,10 +42,7 @@ COPY install/ubuntu_install_rust.sh /install/ubuntu_install_rust.sh
RUN bash /install/ubuntu_install_rust.sh
ENV RUSTUP_HOME /opt/rust
ENV CARGO_HOME /opt/rust
-
-# wasmtime
Review comment:
ok, we can try to remove then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #10001: [CI] Fix Rust path and remove wasmtime from ci_qemu
Posted by GitBox <gi...@apache.org>.
Mousius commented on pull request #10001:
URL: https://github.com/apache/tvm/pull/10001#issuecomment-1017430382
CC @driazati @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #10001: [CI] Fix Rust path and remove wasmtime from ci_qemu
Posted by GitBox <gi...@apache.org>.
areusch merged pull request #10001:
URL: https://github.com/apache/tvm/pull/10001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #10001: [CI] Fix Rust path and remove wasmtime from ci_qemu
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #10001:
URL: https://github.com/apache/tvm/pull/10001#discussion_r789018595
##########
File path: docker/Dockerfile.ci_qemu
##########
@@ -42,10 +42,7 @@ COPY install/ubuntu_install_rust.sh /install/ubuntu_install_rust.sh
RUN bash /install/ubuntu_install_rust.sh
ENV RUSTUP_HOME /opt/rust
ENV CARGO_HOME /opt/rust
-
-# wasmtime
Review comment:
i think this is related to #9844 , should probably keep it cc @driazati
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a change in pull request #10001: [CI] Fix Rust path and remove wasmtime from ci_qemu
Posted by GitBox <gi...@apache.org>.
driazati commented on a change in pull request #10001:
URL: https://github.com/apache/tvm/pull/10001#discussion_r789078411
##########
File path: docker/Dockerfile.ci_qemu
##########
@@ -42,10 +42,7 @@ COPY install/ubuntu_install_rust.sh /install/ubuntu_install_rust.sh
RUN bash /install/ubuntu_install_rust.sh
ENV RUSTUP_HOME /opt/rust
ENV CARGO_HOME /opt/rust
-
-# wasmtime
Review comment:
I'm not sure how it used / if it's actually necessary now that the rust / wasmtime installs are separate, the change in #9844 was mostly mechanical
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org