You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Romain Manni-Bucau (JIRA)" <ji...@apache.org> on 2012/07/19 21:59:36 UTC

[jira] [Commented] (OPENEJB-1028) Better templating to reduce redundant openejb.xml config data

    [ https://issues.apache.org/jira/browse/OPENEJB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418619#comment-13418619 ] 

Romain Manni-Bucau commented on OPENEJB-1028:
---------------------------------------------

isnt it better is the provider is not a resource but...a provider?
                
> Better templating to reduce redundant openejb.xml config data
> -------------------------------------------------------------
>
>                 Key: OPENEJB-1028
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1028
>             Project: OpenEJB
>          Issue Type: Improvement
>          Components: configuration
>            Reporter: David Blevins
>            Assignee: David Blevins
>             Fix For: 3.1.x
>
>         Attachments: ServiceProviderInheritance.txt
>
>
> The idea is that instead of doing this as we currently do:
> <Resource id="My DataSource" type="DataSource">
>   JdbcDriver org.hsqldb.jdbcDriver
>   JdbcUrl jdbc:hsqldb:file:data/hsqldb/hsqldb
>   UserName sa
>   Password
>   JtaManaged true
> </Resource>
> <Resource id="My Unmanaged DataSource" type="DataSource">
>   JdbcDriver org.hsqldb.jdbcDriver
>   JdbcUrl jdbc:hsqldb:file:data/hsqldb/hsqldb
>   UserName sa
>   Password
>   JtaManaged false
> </Resource>
> You can instead utilize the already existing 'provider' attribute to point to things in the openejb.xml file just as you can already use it to point to things declared in a service-jar.xml file.
> <Resource id="My DataSource" type="DataSource">
>   JdbcDriver org.hsqldb.jdbcDriver
>   JdbcUrl jdbc:hsqldb:file:data/hsqldb/hsqldb
>   UserName sa
>   Password
>   JtaManaged true
> </Resource>
> <Resource id="My Unmanaged DataSource" provider="My DataSource">
>   JtaManaged false
> </Resource>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira