[GitHub] [iceberg] nastra commented on a diff in pull request #7398: Core: Allow deleting old partition spec columns in V1

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7398:
URL: https://github.com/apache/iceberg/pull/7398#discussion_r1182468032


##########
core/src/test/java/org/apache/iceberg/TestPartitioning.java:
##########
@@ -386,4 +386,25 @@ public void testGroupingKeyTypeWithIncompatibleSpecEvolution() {
         "Conflicting partition fields",
         () -> Partitioning.groupingKeyType(table.schema(), table.specs().values()));
   }
+
+  @Test
+  public void testDeletingPartitionField() {
+    TestTables.TestTable table =
+        TestTables.create(tableDir, "test", SCHEMA, BY_DATA_SPEC, V1_FORMAT_VERSION);

Review Comment:
   should we maybe also add a test that does the same with `V2_FORMAT_VERSION`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org