You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/15 23:51:06 UTC

[GitHub] [orc] williamhyun commented on a change in pull request #864: ORC-951: Add `since` tag to `org.apache.orc.Reader` interface

williamhyun commented on a change in pull request #864:
URL: https://github.com/apache/orc/pull/864#discussion_r689161977



##########
File path: java/core/src/java/org/apache/orc/Reader.java
##########
@@ -144,23 +160,27 @@
    * Get the file tail (footer + postscript)

Review comment:
       Could you add the tag to `getWriterVersion`? And please check the other functions once more. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org