You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2017/09/09 00:21:00 UTC
[jira] [Commented] (HBASE-12556) Create a golden file for testing
client API source/binary compatibility
[ https://issues.apache.org/jira/browse/HBASE-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159559#comment-16159559 ]
stack commented on HBASE-12556:
-------------------------------
Moving out. Discussion unresolved. JACC has annotation support now, at least in 2.3 -- we ship 2.1 at mo (though I'm not sure it is the same as @busbey desires in his first comment above). Sounds like the 'golden file' maker would be useful and a process run at build time doing compares ([~dimaspivak] suggestion). This is not being worked on so doesn't look like it will make 2.0.0. Moving it out. Meantime I did the old-school manual compare over in HBASE-18622
> Create a golden file for testing client API source/binary compatibility
> -----------------------------------------------------------------------
>
> Key: HBASE-12556
> URL: https://issues.apache.org/jira/browse/HBASE-12556
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: hbase-12556-wip.patch
>
>
> [~lhofhansl] had a suggestion (in some other jira I forgot) for doing a golden file for the HBase API so that we can compare between releases to ensure that we are keeping source and binary compatibility as defined in this document : https://docs.google.com/document/d/1p5pP7v2OuzSSaomK2S2v7sfKky1Hex6OqwsJO0sZTUY/edit
> I think we can generate a file, commit it to the repo, and create a unit test to check whether any API's are broken. Adding new InterfaceAudience.Public interfaces has to modify this file so that it becomes an explicit decision.
> The downside is that we have to modify the file every time we add a new API, but it should be fine since it will force us to think more before committing to supporting new interfaces within the same major versions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)