[jira] [Commented] (IMPALA-9882) Import KLL functionality from DataSketches

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-9882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166238#comment-17166238 ] 

ASF subversion and git services commented on IMPALA-9882:
---------------------------------------------------------

Commit a8fd3213f6e54d73658b66cddcc5b0c955dda283 in impala's branch refs/heads/master from Gabor Kaszab
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a8fd321 ]

IMPALA-9882: Import KLL functionality from Apache DataSketches

First, I updated our existing snapshot of DataSketches to the
following commit:
c67d92faad3827932ca3b5d864222e64977f2c20
"Merge pull request #166 from gaborkaszab/const_cast"
This affects files originated from kll/ and common/ directories of
the DataSketches repo.

Then I copied all the files needed for KLL into our snapshot
directory.

You can find the original Apache DataSketches files here:
https://github.com/apache/incubator-datasketches-cpp

This new snapshot however, broke the interface we used for
serializing hll_union objects with dropping serialize_compact(). As a
solution I had to make changes to the serialization and merging
phases of the union operator by not serializing hll_union itself but
the underlying hll_sketch instead.

Change-Id: I848488d5145c808109bd50aecfbf3ef83f981943
Reviewed-on: http://gerrit.cloudera.org:8080/16196
Reviewed-by: Gabor Kaszab <ga...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Import KLL functionality from DataSketches
> ------------------------------------------
>
>                 Key: IMPALA-9882
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9882
>             Project: IMPALA
>          Issue Type: New Feature
>          Components: Backend
>            Reporter: Gabor Kaszab
>            Assignee: Gabor Kaszab
>            Priority: Major
>
> Import HLL from DataSketches into Impala:
> https://github.com/apache/incubator-datasketches-cpp/tree/master/kll/include
> Include it in the build system and make sure that kll_sketch.hpp can be included into Impala source files and also verify with tests that the basic functionality such as sketch creation, update() and get_quantiles() can be invoked.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org