You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "zhaojinchao95 (via GitHub)" <gi...@apache.org> on 2023/03/10 05:33:21 UTC
[GitHub] [shardingsphere] zhaojinchao95 opened a new pull request, #24537: Add metadata module
zhaojinchao95 opened a new pull request, #24537:
URL: https://github.com/apache/shardingsphere/pull/24537
For #24497 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #24537: Add metadata module
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on code in PR #24537:
URL: https://github.com/apache/shardingsphere/pull/24537#discussion_r1132158787
##########
kernel/metadata/core/src/main/java/org/apache/shardingsphere/metadata/factory/ExternalMetaDataFactory.java:
##########
@@ -72,7 +71,7 @@ public static Map<String, ShardingSphereDatabase> create(final Map<String, Datab
private static Map<String, ShardingSphereDatabase> createGenericDatabases(final Map<String, DatabaseConfiguration> databaseConfigMap, final DatabaseType protocolType,
final ConfigurationProperties props, final InstanceContext instanceContext) throws SQLException {
Map<String, ShardingSphereDatabase> result = new HashMap<>(databaseConfigMap.size(), 1);
- for (Entry<String, DatabaseConfiguration> entry : databaseConfigMap.entrySet()) {
+ for (Map.Entry<String, DatabaseConfiguration> entry : databaseConfigMap.entrySet()) {
Review Comment:
Please remove `Map.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #24537: Add metadata module
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #24537:
URL: https://github.com/apache/shardingsphere/pull/24537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24537: Add metadata module
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24537:
URL: https://github.com/apache/shardingsphere/pull/24537#issuecomment-1463359262
## [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24537?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24537](https://codecov.io/gh/apache/shardingsphere/pull/24537?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0482378) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ea06d6a506edc8186ab68e5dc6545b04ef510363?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea06d6a) will **decrease** coverage by `0.04%`.
> The diff coverage is `30.30%`.
> :exclamation: Current head 0482378 differs from pull request most recent head 2d9e012. Consider uploading reports for the commit 2d9e012 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24537 +/- ##
============================================
- Coverage 50.20% 50.16% -0.04%
Complexity 1599 1599
============================================
Files 3299 3301 +2
Lines 53981 53994 +13
Branches 9927 9930 +3
============================================
- Hits 27100 27087 -13
- Misses 24461 24485 +24
- Partials 2420 2422 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfra/metadata/database/ShardingSphereDatabase.java](https://codecov.io/gh/apache/shardingsphere/pull/24537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9TaGFyZGluZ1NwaGVyZURhdGFiYXNlLmphdmE=) | `66.66% <ø> (-17.95%)` | :arrow_down: |
| [...pache/shardingsphere/metadata/MetaDataFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL21ldGFkYXRhL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldGFkYXRhL01ldGFEYXRhRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...here/metadata/factory/InternalMetaDataFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL21ldGFkYXRhL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldGFkYXRhL2ZhY3RvcnkvSW50ZXJuYWxNZXRhRGF0YUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...nager/standalone/StandaloneModeContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/24537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL3N0YW5kYWxvbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1vZGVDb250ZXh0TWFuYWdlci5qYXZh) | `2.01% <0.00%> (+0.01%)` | :arrow_up: |
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/24537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvQ29udGV4dE1hbmFnZXIuamF2YQ==) | `56.32% <62.50%> (-0.17%)` | :arrow_down: |
| [...here/metadata/factory/ExternalMetaDataFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL21ldGFkYXRhL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldGFkYXRhL2ZhY3RvcnkvRXh0ZXJuYWxNZXRhRGF0YUZhY3RvcnkuamF2YQ==) | `86.36% <75.00%> (ø)` | |
| [...gsphere/mode/metadata/MetaDataContextsFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL01ldGFEYXRhQ29udGV4dHNGYWN0b3J5LmphdmE=) | `79.48% <100.00%> (ø)` | |
| [...ode/manager/cluster/ClusterModeContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/24537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvQ2x1c3Rlck1vZGVDb250ZXh0TWFuYWdlci5qYXZh) | `97.77% <100.00%> (+0.05%)` | :arrow_up: |
... and [2 files with indirect coverage changes](https://codecov.io/gh/apache/shardingsphere/pull/24537/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org