Re: Review Request 21598: Fix for coverity leak and cleanup to use DynamicLibrary

[Niklas Nielsen <ni...@qni.dk>]

> On May 27, 2014, 9:47 a.m., Dominic Hamon wrote:
> >
> 
> Timothy St. Clair wrote:
>     Could Ben or Niklas chime in here, I think we are at an impasse below.

I chatted with Ben about this; how about having a static pointer instead? It could even be within the Jvm::create():

Jvm::create()
{
  ...
  static DynamicLibrary* libJvm = NULL;
  if (libJvm == NULL) {
    libJvm = new DynamicLibrary();
  }
  ...

What do you think?


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21598/#review43981
-----------------------------------------------------------


On May 16, 2014, 7:02 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21598/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 7:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1354
>     https://issues.apache.org/jira/browse/MESOS-1354
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fix for the coverity leak and update the code to leverage stout/dynamiclibrary.
> 
> 
> Diffs
> -----
> 
>   src/jvm/jvm.cpp 745b48f 
> 
> Diff: https://reviews.apache.org/r/21598/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>