You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Antonio Sanso (JIRA)" <ji...@apache.org> on 2012/06/24 17:05:42 UTC
[jira] [Created] (SLING-2518) Exception thrown from
jcrPropertyMap.containsKey("")
Antonio Sanso created SLING-2518:
------------------------------------
Summary: Exception thrown from jcrPropertyMap.containsKey("")
Key: SLING-2518
URL: https://issues.apache.org/jira/browse/SLING-2518
Project: Sling
Issue Type: Bug
Components: JCR
Affects Versions: JCR Resource 2.1.0
Reporter: Antonio Sanso
There is a little regression updating org.apache.sling.jcr.resource from version 2.0.10 to version 2.1
The same call to the JcrPropertyMap#containsKey that used to work in the former version fails in the latest with stacktrace
java.lang.IllegalArgumentException: javax.jcr.RepositoryException: failed to resolve path relative to node /test1340468918488
at org.apache.sling.jcr.resource.JcrPropertyMap.read(JcrPropertyMap.java:355)
at org.apache.sling.jcr.resource.JcrPropertyMap.get(JcrPropertyMap.java:162)
at org.apache.sling.jcr.resource.JcrPropertyMap.containsKey(JcrPropertyMap.java:171)
at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:206)
at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:134)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
if containsKey empty string argument e.g. jcrPropertyMap.containsKey("").
Up to version 2.0.10 jcrPropertyMap.containsKey("") returned false.
See also [0]
[0] sling.markmail.org/message/y4bcxpsreyzt4bwd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2518) Exception thrown from
jcrPropertyMap.containsKey("")
Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso updated SLING-2518:
---------------------------------
Attachment: SLING-2518-test.txt
attaching junit test
> Exception thrown from jcrPropertyMap.containsKey("")
> ----------------------------------------------------
>
> Key: SLING-2518
> URL: https://issues.apache.org/jira/browse/SLING-2518
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.1.0
> Reporter: Antonio Sanso
> Attachments: SLING-2518-test.txt
>
>
> There is a little regression updating org.apache.sling.jcr.resource from version 2.0.10 to version 2.1
> The same call to the JcrPropertyMap#containsKey that used to work in the former version fails in the latest with stacktrace
> java.lang.IllegalArgumentException: javax.jcr.RepositoryException: failed to resolve path relative to node /test1340468918488
> at org.apache.sling.jcr.resource.JcrPropertyMap.read(JcrPropertyMap.java:355)
> at org.apache.sling.jcr.resource.JcrPropertyMap.get(JcrPropertyMap.java:162)
> at org.apache.sling.jcr.resource.JcrPropertyMap.containsKey(JcrPropertyMap.java:171)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:206)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:134)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> if containsKey empty string argument e.g. jcrPropertyMap.containsKey("").
> Up to version 2.0.10 jcrPropertyMap.containsKey("") returned false.
> See also [0]
> [0] sling.markmail.org/message/y4bcxpsreyzt4bwd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2518) Exception thrown from
jcrPropertyMap.containsKey("")
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-2518.
-------------------------------------
Resolution: Fixed
Exception is now swalled for the fallback case and prop names with colon at the beginning are handled properly now. Added a test
> Exception thrown from jcrPropertyMap.containsKey("")
> ----------------------------------------------------
>
> Key: SLING-2518
> URL: https://issues.apache.org/jira/browse/SLING-2518
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.1.0
> Reporter: Antonio Sanso
> Assignee: Carsten Ziegeler
> Fix For: JCR Resource 2.1.2
>
> Attachments: SLING-2518-test.txt
>
>
> There is a little regression updating org.apache.sling.jcr.resource from version 2.0.10 to version 2.1
> The same call to the JcrPropertyMap#containsKey that used to work in the former version fails in the latest with stacktrace
> java.lang.IllegalArgumentException: javax.jcr.RepositoryException: failed to resolve path relative to node /test1340468918488
> at org.apache.sling.jcr.resource.JcrPropertyMap.read(JcrPropertyMap.java:355)
> at org.apache.sling.jcr.resource.JcrPropertyMap.get(JcrPropertyMap.java:162)
> at org.apache.sling.jcr.resource.JcrPropertyMap.containsKey(JcrPropertyMap.java:171)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:206)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:134)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> if containsKey empty string argument e.g. jcrPropertyMap.containsKey("").
> Up to version 2.0.10 jcrPropertyMap.containsKey("") returned false.
> See also [0]
> [0] sling.markmail.org/message/y4bcxpsreyzt4bwd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2518) Exception thrown from
jcrPropertyMap.containsKey("")
Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400556#comment-13400556 ]
Antonio Sanso commented on SLING-2518:
--------------------------------------
thanks for the fix Carsten. While this address this specific case it arguably doesn't fix all the other cases where the exception was "swallowed" though... WDYT?
> Exception thrown from jcrPropertyMap.containsKey("")
> ----------------------------------------------------
>
> Key: SLING-2518
> URL: https://issues.apache.org/jira/browse/SLING-2518
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.1.0
> Reporter: Antonio Sanso
> Assignee: Carsten Ziegeler
> Fix For: JCR Resource 2.1.2
>
> Attachments: SLING-2518-test.txt
>
>
> There is a little regression updating org.apache.sling.jcr.resource from version 2.0.10 to version 2.1
> The same call to the JcrPropertyMap#containsKey that used to work in the former version fails in the latest with stacktrace
> java.lang.IllegalArgumentException: javax.jcr.RepositoryException: failed to resolve path relative to node /test1340468918488
> at org.apache.sling.jcr.resource.JcrPropertyMap.read(JcrPropertyMap.java:355)
> at org.apache.sling.jcr.resource.JcrPropertyMap.get(JcrPropertyMap.java:162)
> at org.apache.sling.jcr.resource.JcrPropertyMap.containsKey(JcrPropertyMap.java:171)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:206)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:134)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> if containsKey empty string argument e.g. jcrPropertyMap.containsKey("").
> Up to version 2.0.10 jcrPropertyMap.containsKey("") returned false.
> See also [0]
> [0] sling.markmail.org/message/y4bcxpsreyzt4bwd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2518) Exception thrown from
jcrPropertyMap.containsKey("")
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-2518.
-------------------------------------
Resolution: Fixed
Fix Version/s: JCR Resource 2.1.2
Thanks for the test, I've added the test and added an extra check for the empty string
> Exception thrown from jcrPropertyMap.containsKey("")
> ----------------------------------------------------
>
> Key: SLING-2518
> URL: https://issues.apache.org/jira/browse/SLING-2518
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.1.0
> Reporter: Antonio Sanso
> Assignee: Carsten Ziegeler
> Fix For: JCR Resource 2.1.2
>
> Attachments: SLING-2518-test.txt
>
>
> There is a little regression updating org.apache.sling.jcr.resource from version 2.0.10 to version 2.1
> The same call to the JcrPropertyMap#containsKey that used to work in the former version fails in the latest with stacktrace
> java.lang.IllegalArgumentException: javax.jcr.RepositoryException: failed to resolve path relative to node /test1340468918488
> at org.apache.sling.jcr.resource.JcrPropertyMap.read(JcrPropertyMap.java:355)
> at org.apache.sling.jcr.resource.JcrPropertyMap.get(JcrPropertyMap.java:162)
> at org.apache.sling.jcr.resource.JcrPropertyMap.containsKey(JcrPropertyMap.java:171)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:206)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:134)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> if containsKey empty string argument e.g. jcrPropertyMap.containsKey("").
> Up to version 2.0.10 jcrPropertyMap.containsKey("") returned false.
> See also [0]
> [0] sling.markmail.org/message/y4bcxpsreyzt4bwd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2518) Exception thrown from
jcrPropertyMap.containsKey("")
Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400568#comment-13400568 ]
Antonio Sanso commented on SLING-2518:
--------------------------------------
theoretically any that used to be like this
} catch (RepositoryException re) {
// TODO: log !!
}
and now is
} catch (final RepositoryException re) {
throw new IllegalArgumentException(re);
}
in the read method.
> Exception thrown from jcrPropertyMap.containsKey("")
> ----------------------------------------------------
>
> Key: SLING-2518
> URL: https://issues.apache.org/jira/browse/SLING-2518
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.1.0
> Reporter: Antonio Sanso
> Assignee: Carsten Ziegeler
> Fix For: JCR Resource 2.1.2
>
> Attachments: SLING-2518-test.txt
>
>
> There is a little regression updating org.apache.sling.jcr.resource from version 2.0.10 to version 2.1
> The same call to the JcrPropertyMap#containsKey that used to work in the former version fails in the latest with stacktrace
> java.lang.IllegalArgumentException: javax.jcr.RepositoryException: failed to resolve path relative to node /test1340468918488
> at org.apache.sling.jcr.resource.JcrPropertyMap.read(JcrPropertyMap.java:355)
> at org.apache.sling.jcr.resource.JcrPropertyMap.get(JcrPropertyMap.java:162)
> at org.apache.sling.jcr.resource.JcrPropertyMap.containsKey(JcrPropertyMap.java:171)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:206)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:134)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> if containsKey empty string argument e.g. jcrPropertyMap.containsKey("").
> Up to version 2.0.10 jcrPropertyMap.containsKey("") returned false.
> See also [0]
> [0] sling.markmail.org/message/y4bcxpsreyzt4bwd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2518) Exception thrown from
jcrPropertyMap.containsKey("")
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reassigned SLING-2518:
---------------------------------------
Assignee: Carsten Ziegeler
> Exception thrown from jcrPropertyMap.containsKey("")
> ----------------------------------------------------
>
> Key: SLING-2518
> URL: https://issues.apache.org/jira/browse/SLING-2518
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.1.0
> Reporter: Antonio Sanso
> Assignee: Carsten Ziegeler
> Attachments: SLING-2518-test.txt
>
>
> There is a little regression updating org.apache.sling.jcr.resource from version 2.0.10 to version 2.1
> The same call to the JcrPropertyMap#containsKey that used to work in the former version fails in the latest with stacktrace
> java.lang.IllegalArgumentException: javax.jcr.RepositoryException: failed to resolve path relative to node /test1340468918488
> at org.apache.sling.jcr.resource.JcrPropertyMap.read(JcrPropertyMap.java:355)
> at org.apache.sling.jcr.resource.JcrPropertyMap.get(JcrPropertyMap.java:162)
> at org.apache.sling.jcr.resource.JcrPropertyMap.containsKey(JcrPropertyMap.java:171)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:206)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:134)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> if containsKey empty string argument e.g. jcrPropertyMap.containsKey("").
> Up to version 2.0.10 jcrPropertyMap.containsKey("") returned false.
> See also [0]
> [0] sling.markmail.org/message/y4bcxpsreyzt4bwd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2518) Exception thrown from
jcrPropertyMap.containsKey("")
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400560#comment-13400560 ]
Carsten Ziegeler commented on SLING-2518:
-----------------------------------------
Which cases do you mean?
> Exception thrown from jcrPropertyMap.containsKey("")
> ----------------------------------------------------
>
> Key: SLING-2518
> URL: https://issues.apache.org/jira/browse/SLING-2518
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.1.0
> Reporter: Antonio Sanso
> Assignee: Carsten Ziegeler
> Fix For: JCR Resource 2.1.2
>
> Attachments: SLING-2518-test.txt
>
>
> There is a little regression updating org.apache.sling.jcr.resource from version 2.0.10 to version 2.1
> The same call to the JcrPropertyMap#containsKey that used to work in the former version fails in the latest with stacktrace
> java.lang.IllegalArgumentException: javax.jcr.RepositoryException: failed to resolve path relative to node /test1340468918488
> at org.apache.sling.jcr.resource.JcrPropertyMap.read(JcrPropertyMap.java:355)
> at org.apache.sling.jcr.resource.JcrPropertyMap.get(JcrPropertyMap.java:162)
> at org.apache.sling.jcr.resource.JcrPropertyMap.containsKey(JcrPropertyMap.java:171)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:206)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:134)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> if containsKey empty string argument e.g. jcrPropertyMap.containsKey("").
> Up to version 2.0.10 jcrPropertyMap.containsKey("") returned false.
> See also [0]
> [0] sling.markmail.org/message/y4bcxpsreyzt4bwd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2518) Exception thrown from
jcrPropertyMap.containsKey("")
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400584#comment-13400584 ]
Carsten Ziegeler commented on SLING-2518:
-----------------------------------------
Ah right, I think in this case swallowing the exception is wrong (= bug), so the new behaviour is more correct.
Previously, if for whatever reason a property couldn't be read, it was reported as non existing. If some action is done, if a property is not existing, this could lead to problems further down the line. Now, you get the exception directly into your face :)
> Exception thrown from jcrPropertyMap.containsKey("")
> ----------------------------------------------------
>
> Key: SLING-2518
> URL: https://issues.apache.org/jira/browse/SLING-2518
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.1.0
> Reporter: Antonio Sanso
> Assignee: Carsten Ziegeler
> Fix For: JCR Resource 2.1.2
>
> Attachments: SLING-2518-test.txt
>
>
> There is a little regression updating org.apache.sling.jcr.resource from version 2.0.10 to version 2.1
> The same call to the JcrPropertyMap#containsKey that used to work in the former version fails in the latest with stacktrace
> java.lang.IllegalArgumentException: javax.jcr.RepositoryException: failed to resolve path relative to node /test1340468918488
> at org.apache.sling.jcr.resource.JcrPropertyMap.read(JcrPropertyMap.java:355)
> at org.apache.sling.jcr.resource.JcrPropertyMap.get(JcrPropertyMap.java:162)
> at org.apache.sling.jcr.resource.JcrPropertyMap.containsKey(JcrPropertyMap.java:171)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:206)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:134)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> if containsKey empty string argument e.g. jcrPropertyMap.containsKey("").
> Up to version 2.0.10 jcrPropertyMap.containsKey("") returned false.
> See also [0]
> [0] sling.markmail.org/message/y4bcxpsreyzt4bwd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (SLING-2518) Exception thrown from
jcrPropertyMap.containsKey("")
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reopened SLING-2518:
-------------------------------------
When a get with a property is done which starts with a ":", this results in an IllegalArgumentException now.
This is due to the support of the old encoding and throwing an exception in case something goes wrong.
If the fallback is reached we should swallow the exception like we did before - and in addition we should handle the case where the ":" is at the beginning of the name
> Exception thrown from jcrPropertyMap.containsKey("")
> ----------------------------------------------------
>
> Key: SLING-2518
> URL: https://issues.apache.org/jira/browse/SLING-2518
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.1.0
> Reporter: Antonio Sanso
> Assignee: Carsten Ziegeler
> Fix For: JCR Resource 2.1.2
>
> Attachments: SLING-2518-test.txt
>
>
> There is a little regression updating org.apache.sling.jcr.resource from version 2.0.10 to version 2.1
> The same call to the JcrPropertyMap#containsKey that used to work in the former version fails in the latest with stacktrace
> java.lang.IllegalArgumentException: javax.jcr.RepositoryException: failed to resolve path relative to node /test1340468918488
> at org.apache.sling.jcr.resource.JcrPropertyMap.read(JcrPropertyMap.java:355)
> at org.apache.sling.jcr.resource.JcrPropertyMap.get(JcrPropertyMap.java:162)
> at org.apache.sling.jcr.resource.JcrPropertyMap.containsKey(JcrPropertyMap.java:171)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:206)
> at org.apache.sling.jcr.resource.internal.JcrPropertyMapTest.testDefaultValue(JcrPropertyMapTest.java:134)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> if containsKey empty string argument e.g. jcrPropertyMap.containsKey("").
> Up to version 2.0.10 jcrPropertyMap.containsKey("") returned false.
> See also [0]
> [0] sling.markmail.org/message/y4bcxpsreyzt4bwd
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira