[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1037: IGNITE-17510 NPE in cluster configuration REST calls

[GitBox <gi...@apache.org>]

PakhomovAlexander commented on code in PR #1037:
URL: https://github.com/apache/ignite-3/pull/1037#discussion_r955912646


##########
modules/rest/openapi/openapi.yaml:
##########
@@ -410,7 +442,6 @@ components:
     Problem:
       required:
       - code
-      - detail
       - invalidParams

Review Comment:
   Do we reallly need to mark `detail` as not requered? This is not the only field that might be not requered here.



##########
modules/rest-api/src/main/java/org/apache/ignite/internal/rest/exception/handler/AllExceptionHandler.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.rest.exception.handler;
+
+import io.micronaut.context.annotation.Requires;
+import io.micronaut.http.HttpRequest;
+import io.micronaut.http.HttpResponse;
+import io.micronaut.http.server.exceptions.ExceptionHandler;
+import jakarta.inject.Singleton;
+import org.apache.ignite.internal.rest.api.Problem;
+import org.apache.ignite.internal.rest.constants.HttpCode;
+import org.apache.ignite.internal.rest.problem.HttpProblemResponse;
+
+/**
+ * Handles {@link Exception} and represents it as an application/problem+json response.
+ * This will catch all unhandled exceptions since all REST endpoints are marked as producing problem json.
+ */
+@Singleton
+@Requires(classes = {Exception.class, ExceptionHandler.class})
+public class AllExceptionHandler implements

Review Comment:
   I would suggest logging the exception here because it might be a bug that has to be fixed. And the name of this Exception handler might be JavaExceptionHandler (IgniteExceptionHandler alredy exists).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org