You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/06/07 00:16:27 UTC
[kudu-CR] [backup] Make KuduBackupCLI format optional
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13551
Change subject: [backup] Make KuduBackupCLI format optional
......................................................................
[backup] Make KuduBackupCLI format optional
This patch changes the KuduBackupCLI to not require a
positional format and instead use `--format` with a
default value of “pretty”.
Change-Id: I15e0270a94844ffb7cb804a182dcf9699dd12ec7
---
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCLI.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupCLI.scala
2 files changed, 16 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/13551/1
--
To view, visit http://gerrit.cloudera.org:8080/13551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15e0270a94844ffb7cb804a182dcf9699dd12ec7
Gerrit-Change-Number: 13551
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [backup] Make KuduBackupCLI executable
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13551 )
Change subject: [backup] Make KuduBackupCLI executable
......................................................................
[backup] Make KuduBackupCLI executable
This patch changes the KuduBackupCLI to be the
defacto main class of the kudu-backup-tools. It
does this by combining both the GC tool and the
list tool into a single CLI parser.
I tested this by running:
`java -jar build/libs/kudu-backup-tools-1.10.0-SNAPSHOT.jar`
Change-Id: I15e0270a94844ffb7cb804a182dcf9699dd12ec7
Reviewed-on: http://gerrit.cloudera.org:8080/13551
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M java/kudu-backup-tools/build.gradle
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCLI.scala
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCleaner.scala
A java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupLister.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupCleaner.scala
R java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupLister.scala
6 files changed, 275 insertions(+), 229 deletions(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15e0270a94844ffb7cb804a182dcf9699dd12ec7
Gerrit-Change-Number: 13551
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [backup] Make KuduBackupCLI executable
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13551
to look at the new patch set (#2).
Change subject: [backup] Make KuduBackupCLI executable
......................................................................
[backup] Make KuduBackupCLI executable
This patch changes the KuduBackupCLI to be the
defacto main class of the kudu-backup-tools. It
does this by combining both the GC tool and the
list tool into a single CLI parser.
I tested this by running:
`java -jar build/libs/kudu-backup-tools-1.10.0-SNAPSHOT.jar`
Change-Id: I15e0270a94844ffb7cb804a182dcf9699dd12ec7
---
M java/kudu-backup-tools/build.gradle
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCLI.scala
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCleaner.scala
A java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupLister.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupCleaner.scala
R java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupLister.scala
6 files changed, 275 insertions(+), 229 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/13551/2
--
To view, visit http://gerrit.cloudera.org:8080/13551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15e0270a94844ffb7cb804a182dcf9699dd12ec7
Gerrit-Change-Number: 13551
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [backup] Make KuduBackupCLI format optional
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [backup] Make KuduBackupCLI format optional
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I15e0270a94844ffb7cb804a182dcf9699dd12ec7
Gerrit-Change-Number: 13551
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [backup] Make KuduBackupCLI executable
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13551 )
Change subject: [backup] Make KuduBackupCLI executable
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15e0270a94844ffb7cb804a182dcf9699dd12ec7
Gerrit-Change-Number: 13551
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 22:24:05 +0000
Gerrit-HasComments: No
[kudu-CR] [backup] Make KuduBackupCLI format optional
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13551 )
Change subject: [backup] Make KuduBackupCLI format optional
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15e0270a94844ffb7cb804a182dcf9699dd12ec7
Gerrit-Change-Number: 13551
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:15:38 +0000
Gerrit-HasComments: No