You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by "David Lutterkort (JIRA)" <ji...@apache.org> on 2011/02/18 02:25:12 UTC

[jira] Created: (DTACLOUD-18) Missing Host header not handled

Missing Host header not handled
-------------------------------

                 Key: DTACLOUD-18
                 URL: https://issues.apache.org/jira/browse/DTACLOUD-18
             Project: DeltaCloud
          Issue Type: Bug
            Reporter: David Lutterkort
            Assignee: David Lutterkort
            Priority: Minor


According to HTTP 1.1[1], requests must have a Host header. If the header is missing, the response should be a '400 Bad request'

Right now, we carry on and produce improper results, since URL's embedded in responses either do not contain the port number, or have port number 0. Example:

> curl -H 'Host:' http://localhost:3001/api

<api driver='mock' version='0.2.0'>
  <link href='http://localhost:0/api/buckets' rel='buckets'>
  </link>
  ...
</api>

[1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (DTACLOUD-18) Missing Host header not handled

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DTACLOUD-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116030#comment-13116030 ] 

Hudson commented on DTACLOUD-18:
--------------------------------

Integrated in apache-deltacloud-core #321 (See [https://builds.apache.org/job/apache-deltacloud-core/321/])
    * server/server.rb: respond with status 400 when Host header is missing

Fixes DTACLOUD-18

Signed-off-by: Davanum Srinivas <di...@apache.org>

lutter : http://svn.apache.org/viewvc/?view=rev&rev=1176662
Files : 
* /incubator/deltacloud/trunk/server/server.rb

                
> Missing Host header not handled
> -------------------------------
>
>                 Key: DTACLOUD-18
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-18
>             Project: DeltaCloud
>          Issue Type: Bug
>            Reporter: David Lutterkort
>            Assignee: David Lutterkort
>            Priority: Minor
>
> According to HTTP 1.1[1], requests must have a Host header. If the header is missing, the response should be a '400 Bad request'
> Right now, we carry on and produce improper results, since URL's embedded in responses either do not contain the port number, or have port number 0. Example:
> > curl -H 'Host:' http://localhost:3001/api
> <api driver='mock' version='0.2.0'>
>   <link href='http://localhost:0/api/buckets' rel='buckets'>
>   </link>
>   ...
> </api>
> Thanks to Lili Nader for persisting in getting to the bottom of this.
> [1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (DTACLOUD-18) Missing Host header not handled

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DTACLOUD-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114370#comment-13114370 ] 

Davanum Srinivas commented on DTACLOUD-18:
------------------------------------------

Sent a patch to the dev list for review - http://markmail.org/message/kybvlgxthzlxtu2y

> Missing Host header not handled
> -------------------------------
>
>                 Key: DTACLOUD-18
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-18
>             Project: DeltaCloud
>          Issue Type: Bug
>            Reporter: David Lutterkort
>            Assignee: David Lutterkort
>            Priority: Minor
>
> According to HTTP 1.1[1], requests must have a Host header. If the header is missing, the response should be a '400 Bad request'
> Right now, we carry on and produce improper results, since URL's embedded in responses either do not contain the port number, or have port number 0. Example:
> > curl -H 'Host:' http://localhost:3001/api
> <api driver='mock' version='0.2.0'>
>   <link href='http://localhost:0/api/buckets' rel='buckets'>
>   </link>
>   ...
> </api>
> Thanks to Lili Nader for persisting in getting to the bottom of this.
> [1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (DTACLOUD-18) Missing Host header not handled

Posted by "David Lutterkort (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DTACLOUD-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Lutterkort resolved DTACLOUD-18.
--------------------------------------

    Resolution: Fixed

Fixed with the patch from dims, svn r1176662
                
> Missing Host header not handled
> -------------------------------
>
>                 Key: DTACLOUD-18
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-18
>             Project: DeltaCloud
>          Issue Type: Bug
>            Reporter: David Lutterkort
>            Assignee: David Lutterkort
>            Priority: Minor
>
> According to HTTP 1.1[1], requests must have a Host header. If the header is missing, the response should be a '400 Bad request'
> Right now, we carry on and produce improper results, since URL's embedded in responses either do not contain the port number, or have port number 0. Example:
> > curl -H 'Host:' http://localhost:3001/api
> <api driver='mock' version='0.2.0'>
>   <link href='http://localhost:0/api/buckets' rel='buckets'>
>   </link>
>   ...
> </api>
> Thanks to Lili Nader for persisting in getting to the bottom of this.
> [1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DTACLOUD-18) Missing Host header not handled

Posted by "David Lutterkort (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DTACLOUD-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Lutterkort updated DTACLOUD-18:
-------------------------------------

    Description: 
According to HTTP 1.1[1], requests must have a Host header. If the header is missing, the response should be a '400 Bad request'

Right now, we carry on and produce improper results, since URL's embedded in responses either do not contain the port number, or have port number 0. Example:

> curl -H 'Host:' http://localhost:3001/api

<api driver='mock' version='0.2.0'>
  <link href='http://localhost:0/api/buckets' rel='buckets'>
  </link>
  ...
</api>

Thanks to Lili Nader for persisting in getting to the bottom of this.

[1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

  was:
According to HTTP 1.1[1], requests must have a Host header. If the header is missing, the response should be a '400 Bad request'

Right now, we carry on and produce improper results, since URL's embedded in responses either do not contain the port number, or have port number 0. Example:

> curl -H 'Host:' http://localhost:3001/api

<api driver='mock' version='0.2.0'>
  <link href='http://localhost:0/api/buckets' rel='buckets'>
  </link>
  ...
</api>

[1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html


> Missing Host header not handled
> -------------------------------
>
>                 Key: DTACLOUD-18
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-18
>             Project: DeltaCloud
>          Issue Type: Bug
>            Reporter: David Lutterkort
>            Assignee: David Lutterkort
>            Priority: Minor
>
> According to HTTP 1.1[1], requests must have a Host header. If the header is missing, the response should be a '400 Bad request'
> Right now, we carry on and produce improper results, since URL's embedded in responses either do not contain the port number, or have port number 0. Example:
> > curl -H 'Host:' http://localhost:3001/api
> <api driver='mock' version='0.2.0'>
>   <link href='http://localhost:0/api/buckets' rel='buckets'>
>   </link>
>   ...
> </api>
> Thanks to Lili Nader for persisting in getting to the bottom of this.
> [1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira