You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Yegor Kozlov <ye...@dinom.ru> on 2011/08/23 21:04:34 UTC

[VOTE] Release POI 3.8 beta4 - Take 2

Hi All,

Please test-drive the release candidate for POI 3.8 beta4 (take 2).
Compared to the first version, two release blockers have been found and fixed:

 (1) https://issues.apache.org/bugzilla/show_bug.cgi?id=51686
 (2) Our collection of test files included a document that we are not
allowed to distribute.  The doc in question has been removed.

The release candidate files are available from:

https://dist.apache.org/repos/dist/dev/poi/

(The jars and poms to feed into the maven repo are in /maven/
directory, they will be pushed using mvn-deploy.sh)

As with all Apache release votes, please check that not only does the
code work, and no major breakages have occurred since the last
release, but also that packaging is correct, license headers and
notices exist etc.

The vote options are:

 +1 - I support this release
 0 - I don't object to this release, but I haven't checked it
 -1 - There's a problem with the release, and that is ....

I'm voting [+1]. Vote open for 72 hours and ends on Friday, 26th August.

Yegor

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Sergey Vladimirov <vl...@gmail.com>.
[+1] from me.
No test faults in our POI-related components.

-- 
Sergey

On Tue, Aug 23, 2011 at 11:04 PM, Yegor Kozlov <ye...@dinom.ru> wrote:
> Hi All,
>
> Please test-drive the release candidate for POI 3.8 beta4 (take 2).
> Compared to the first version, two release blockers have been found and fixed:
>
>  (1) https://issues.apache.org/bugzilla/show_bug.cgi?id=51686
>  (2) Our collection of test files included a document that we are not
> allowed to distribute.  The doc in question has been removed.
>
> The release candidate files are available from:
>
> https://dist.apache.org/repos/dist/dev/poi/
>
> (The jars and poms to feed into the maven repo are in /maven/
> directory, they will be pushed using mvn-deploy.sh)
>
> As with all Apache release votes, please check that not only does the
> code work, and no major breakages have occurred since the last
> release, but also that packaging is correct, license headers and
> notices exist etc.
>
> The vote options are:
>
>  +1 - I support this release
>  0 - I don't object to this release, but I haven't checked it
>  -1 - There's a problem with the release, and that is ....
>
> I'm voting [+1]. Vote open for 72 hours and ends on Friday, 26th August.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Dave Fisher <da...@comcast.net>.
On Aug 25, 2011, at 3:22 AM, Nick Burch wrote:

> On Thu, 25 Aug 2011, Yegor Kozlov wrote:
>> Dave and Nick,
>> Is it really a blocker? Can I have provisional +1 from you, providing
>> that the the problem fixed in trunk ASAP?
> 
> It's certainly a blocker on a final release. On a test file, on a beta release, I'm less sure

I waver myself.

> 
>> If a missing ASF licence header is considered to be a blocker, then rat-check MUST be a part of the "dist" task to prevent such issues in the future.
> 
> I'd suggest that if rat isn't present, a warning is raised but the build continues. The release manager should be instructed to always have Rat installed. That way, people who take the POI codebase and tweak things can still do their own custom builds, but we get the check

+1 to this.

I think reviewers ought to have Rat and Forrest 0.5 installed.

We should have improved instructions for release reviewers with example commands. It is cumbersome to deal with the keys and there are missing bits. Let's see if we agree on the steps.

(1) Verify artifacts - check signatures and checksums.
(2) Check that the zip and tar.gz artifacts unpack to the same content.
(3) Perform a full dist build of the source distribution. Check Unit Tests and RAT report.
(4) Check docs website from binary distro with built version.

Anything else?

Regards,
Dave

> 
> Nick
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Nick Burch <ni...@alfresco.com>.
On Thu, 25 Aug 2011, Yegor Kozlov wrote:
> Dave and Nick,
> Is it really a blocker? Can I have provisional +1 from you, providing
> that the the problem fixed in trunk ASAP?

It's certainly a blocker on a final release. On a test file, on a beta 
release, I'm less sure

> If a missing ASF licence header is considered to be a blocker, then 
> rat-check MUST be a part of the "dist" task to prevent such issues in 
> the future.

I'd suggest that if rat isn't present, a warning is raised but the build 
continues. The release manager should be instructed to always have Rat 
installed. That way, people who take the POI codebase and tweak things can 
still do their own custom builds, but we get the check

Nick

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Yegor Kozlov <ye...@dinom.ru>.
I did run rat-check before Take 1 and fixed a number of issues, see
r1156541. But I didn't run it before Take 2, that is why
TestNumberFormatter.java cropped up - it was checked-in on Aug 17 ,
between two takes.

Dave and Nick,
Is it really a blocker? Can I have provisional +1 from you, providing
that the the problem fixed in trunk ASAP?

Otherwise, I'm going to abort the vote and take time to improve the
release procedure. If a missing ASF licence header is considered to be
a blocker, then rat-check MUST be a part of the "dist" task to prevent
such issues in the future.

Missing licence in log4.properties is not important, this file is not
used and can be dropped.

Yegor

On Thu, Aug 25, 2011 at 2:52 AM, Nick Burch <ni...@alfresco.com> wrote:
> On Wed, 24 Aug 2011, Dave Fisher wrote:
>>
>> RAT reports files that are missing Apache License headers. One or two need
>> attention. They are in testcases and I am reluctant to call them blockers.
>
> That's a shame, as I think that missing license headers do generally count
> as a blocker even on beta releases. Just see general@incubator for many
> examples of this...
>
> I thought I had added something to the release guide about checking rat to
> avoid this problem (pretty sure it's bitten me too once...!) It's step 7 in
> the pre-requisite section of the release-guide.txt, but maybe it wants to be
> moved somewhere else. FWIW, I know of several projects where the rat check
> is actually part of the dist step, and the dist will abort if the rat check
> isn't clean, which helps flag it up nice and early!
>
> Nick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Dave Fisher <da...@comcast.net>.
On Aug 25, 2011, at 1:38 AM, Nick Burch wrote:

> On Wed, 24 Aug 2011, Dave Fisher wrote:
>> Do you have a project that we could copy. If so, I'll throw it into the poi build.xml and see what's up.
> 
> I can do one better, it's already in our build.xml :)
> 
> Assuming you've installed the rat plugin in your ant lib (~/.ant/lib/) then you just need to do "ant rat-check"

Works well.

BTW - Trunk now passes and using the build's rat the release candidate only shows the two files.

Regards,
Dave

> 
> Nick
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Nick Burch <ni...@alfresco.com>.
On Wed, 24 Aug 2011, Dave Fisher wrote:
> Do you have a project that we could copy. If so, I'll throw it into the 
> poi build.xml and see what's up.

I can do one better, it's already in our build.xml :)

Assuming you've installed the rat plugin in your ant lib (~/.ant/lib/) 
then you just need to do "ant rat-check"

Nick

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Dave Fisher <da...@comcast.net>.
On Aug 24, 2011, at 4:11 PM, Nick Burch wrote:

> On Wed, 24 Aug 2011, Dave Fisher wrote:
>> I think we have been accepting the dummy.txt, *.pen and *.dtd as exceptions.
> 
> The dummy ones should be being excluded already, though possibly they're not due to a recent re-org. Ditto .pen and .dtd. Just to check - are you using the "rat-check" ant target to do your checks? That has a set of excludes included in it which should skip over the bits that are safe to ignore the lack of headers in

I followed the rather thin example in the podling and did a license check:

java -jar ../../apache-rat-0.7/apache-rat-0.7.jar --addLicence /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src

I see some instructions here: http://incubator.apache.org/rat/apache-rat-tasks/index.html

Do you have a project that we could copy. If so, I'll throw it into the poi build.xml and see what's up.

Regards,
Dave



> 
> Nick
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Nick Burch <ni...@alfresco.com>.
On Wed, 24 Aug 2011, Dave Fisher wrote:
> I think we have been accepting the dummy.txt, *.pen and *.dtd as 
> exceptions.

The dummy ones should be being excluded already, though possibly they're 
not due to a recent re-org. Ditto .pen and .dtd. Just to check - are you 
using the "rat-check" ant target to do your checks? That has a set of 
excludes included in it which should skip over the bits that are safe to 
ignore the lack of headers in

Nick

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Dave Fisher <da...@comcast.net>.
Then I withdraw my +1 vote.

Sorry about that Yegor, time for Take 3. If you roll tonight I'll check tomorrow.

Regards,
Dave

On Aug 24, 2011, at 3:52 PM, Nick Burch wrote:

> On Wed, 24 Aug 2011, Dave Fisher wrote:
>> RAT reports files that are missing Apache License headers. One or two need attention. They are in testcases and I am reluctant to call them blockers.
> 
> That's a shame, as I think that missing license headers do generally count as a blocker even on beta releases. Just see general@incubator for many examples of this...

OK.

> 
> I thought I had added something to the release guide about checking rat to avoid this problem (pretty sure it's bitten me too once...!) It's step 7 in the pre-requisite section of the release-guide.txt, but maybe it wants to be moved somewhere else. FWIW, I know of several projects where the rat check is actually part of the dist step, and the dist will abort if the rat check isn't clean, which helps flag it up nice and early!

This was the first time I've used RAT... It will also check signatures, etc.

I think we have been accepting the dummy.txt, *.pen and *.dtd as exceptions.

BTW -

Summary
-------
Notes: 3
Binaries: 119
Archives: 0
Standards: 2768

Apache Licensed: 2746
Generated Documents: 0

JavaDocs are generated and so license header is optional
Generated files do not required license headers

22 Unknown Licenses

*******************************

Unapproved licenses:

  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/contrib/testcases/dummy.txt
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/ISOdia.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/ISOlat1.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/ISOnum.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/ISOpub.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/ISOtech.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/book-cocoon-v10.dtd
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/changes-v11.dtd
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/document-v11.dtd
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/faq-v11.dtd
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/javadoc-v04draft.dtd
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/specification-v11.dtd
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOdia.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOgrk1.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOlat1.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOnum.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOpub.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOtech.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/examples/lib/dummy.txt
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/scratchpad/testcases/dummy.txt
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/scratchpad/testcases/log4j.properties
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/scratchpad/testcases/org/apache/poi/hwpf/converter/TestNumberFormatter.java

*******************************



> 
> Nick
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Nick Burch <ni...@alfresco.com>.
On Wed, 24 Aug 2011, Dave Fisher wrote:
> RAT reports files that are missing Apache License headers. One or two 
> need attention. They are in testcases and I am reluctant to call them 
> blockers.

That's a shame, as I think that missing license headers do generally count 
as a blocker even on beta releases. Just see general@incubator for many 
examples of this...

I thought I had added something to the release guide about checking rat to 
avoid this problem (pretty sure it's bitten me too once...!) It's step 7 
in the pre-requisite section of the release-guide.txt, but maybe it wants 
to be moved somewhere else. FWIW, I know of several projects where the rat 
check is actually part of the dist step, and the dist will abort if the 
rat check isn't clean, which helps flag it up nice and early!

Nick

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Dave Fisher <da...@comcast.net>.
Hi,

RAT reports files that are missing Apache License headers. One or two need attention. They are in testcases and I am reluctant to call them blockers.

$ svn log src/scratchpad/testcases/org/apache/poi/hwpf/converter/TestNumberFormatter.java
------------------------------------------------------------------------
r1158701 | sergey | 2011-08-17 06:47:51 -0700 (Wed, 17 Aug 2011) | 1 line

translate almost any number to english and roman letters
------------------------------------------------------------------------

$ svn log src/scratchpad/testcases/log4j.properties
------------------------------------------------------------------------
r1148002 | sergey | 2011-07-18 11:44:03 -0700 (Mon, 18 Jul 2011) | 1 line

fix Bug 51524 -- PapBinTable constructor is slow (regression)
------------------------------------------------------------------------

My vote is +1.

Regards,
Dave


On Aug 23, 2011, at 12:04 PM, Yegor Kozlov wrote:

> Hi All,
> 
> Please test-drive the release candidate for POI 3.8 beta4 (take 2).
> Compared to the first version, two release blockers have been found and fixed:
> 
> (1) https://issues.apache.org/bugzilla/show_bug.cgi?id=51686
> (2) Our collection of test files included a document that we are not
> allowed to distribute.  The doc in question has been removed.
> 
> The release candidate files are available from:
> 
> https://dist.apache.org/repos/dist/dev/poi/
> 
> (The jars and poms to feed into the maven repo are in /maven/
> directory, they will be pushed using mvn-deploy.sh)
> 
> As with all Apache release votes, please check that not only does the
> code work, and no major breakages have occurred since the last
> release, but also that packaging is correct, license headers and
> notices exist etc.
> 
> The vote options are:
> 
> +1 - I support this release
> 0 - I don't object to this release, but I haven't checked it
> -1 - There's a problem with the release, and that is ....
> 
> I'm voting [+1]. Vote open for 72 hours and ends on Friday, 26th August.
> 
> Yegor
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Dave Fisher <da...@comcast.net>.
OK - I am +1

Regards,
Dave

On Aug 23, 2011, at 12:04 PM, Yegor Kozlov wrote:

> Hi All,
> 
> Please test-drive the release candidate for POI 3.8 beta4 (take 2).
> Compared to the first version, two release blockers have been found and fixed:
> 
> (1) https://issues.apache.org/bugzilla/show_bug.cgi?id=51686
> (2) Our collection of test files included a document that we are not
> allowed to distribute.  The doc in question has been removed.
> 
> The release candidate files are available from:
> 
> https://dist.apache.org/repos/dist/dev/poi/
> 
> (The jars and poms to feed into the maven repo are in /maven/
> directory, they will be pushed using mvn-deploy.sh)
> 
> As with all Apache release votes, please check that not only does the
> code work, and no major breakages have occurred since the last
> release, but also that packaging is correct, license headers and
> notices exist etc.
> 
> The vote options are:
> 
> +1 - I support this release
> 0 - I don't object to this release, but I haven't checked it
> -1 - There's a problem with the release, and that is ....
> 
> I'm voting [+1]. Vote open for 72 hours and ends on Friday, 26th August.
> 
> Yegor
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Yegor Kozlov <ye...@dinom.ru>.
The vote has passed.
Four +1 votes, zero -1 votes. Four +1 from PMC.

The vote thread is
http://mail-archives.apache.org/mod_mbox/poi-dev/201108.mbox/%3CCAAwi-j_NskSDQKmdqsh4xyOrii3N-ythu+V0griEHSqg9SE2DA@mail.gmail.com%3E

Yegor

On Tue, Aug 23, 2011 at 11:04 PM, Yegor Kozlov <ye...@dinom.ru> wrote:
> Hi All,
>
> Please test-drive the release candidate for POI 3.8 beta4 (take 2).
> Compared to the first version, two release blockers have been found and fixed:
>
>  (1) https://issues.apache.org/bugzilla/show_bug.cgi?id=51686
>  (2) Our collection of test files included a document that we are not
> allowed to distribute.  The doc in question has been removed.
>
> The release candidate files are available from:
>
> https://dist.apache.org/repos/dist/dev/poi/
>
> (The jars and poms to feed into the maven repo are in /maven/
> directory, they will be pushed using mvn-deploy.sh)
>
> As with all Apache release votes, please check that not only does the
> code work, and no major breakages have occurred since the last
> release, but also that packaging is correct, license headers and
> notices exist etc.
>
> The vote options are:
>
>  +1 - I support this release
>  0 - I don't object to this release, but I haven't checked it
>  -1 - There's a problem with the release, and that is ....
>
> I'm voting [+1]. Vote open for 72 hours and ends on Friday, 26th August.
>
> Yegor
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Maxim Valyanskiy <ma...@jet.msk.su>.
+1

23.08.2011 23:04, Yegor Kozlov пишет:
> Hi All,
>
> Please test-drive the release candidate for POI 3.8 beta4 (take 2).
> Compared to the first version, two release blockers have been found and fixed:
>
>   (1) https://issues.apache.org/bugzilla/show_bug.cgi?id=51686
>   (2) Our collection of test files included a document that we are not
> allowed to distribute.  The doc in question has been removed.
>
> The release candidate files are available from:
>
> https://dist.apache.org/repos/dist/dev/poi/
>
> (The jars and poms to feed into the maven repo are in /maven/
> directory, they will be pushed using mvn-deploy.sh)
>
> As with all Apache release votes, please check that not only does the
> code work, and no major breakages have occurred since the last
> release, but also that packaging is correct, license headers and
> notices exist etc.
>
> The vote options are:
>
>   +1 - I support this release
>   0 - I don't object to this release, but I haven't checked it
>   -1 - There's a problem with the release, and that is ....
>
> I'm voting [+1]. Vote open for 72 hours and ends on Friday, 26th August.
>
> Yegor
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Dave Fisher <da...@comcast.net>.
On Aug 23, 2011, at 11:14 PM, Yegor Kozlov wrote:

> All the signatures are correct. I used the same signing procedure as
> for old releases, it signs all files in a batch and I didn't do
> anything different for .zip and .gz files. Moreover, I used
> multisign.sh which is a tried and tested script from the release
> tools, see  tools/releases/multisign.sh in the ASF committers
> repository.
> 
> I think it is a problem in the GPGTools for Mac OS X.

Well when I check the signature on RAT's tar.gz it works as expected.

$ gpg --verify apache-rat-incubating-current-bin.tar.gz.asc
gpg: Signature made Fri Jul 30 13:56:55 2010 PDT using DSA key ID DE240A64
gpg: Good signature from "Jochen Wiedmann <jo...@apache.org>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.

> 
> I'm checking with with GNU gpg on Windows / cygwin and on Linux and
> all signatures are fine.

I am viewing this as something to correct for POI-3.8 Final. Strange that there is a difference in how GPG tools process *.tar.gz

Regards,
Dave


> 
> Yegor
> 
> On Wed, Aug 24, 2011 at 5:34 AM, Dave Fisher <da...@comcast.net> wrote:
>> Hi Yegor,
>> 
>> I'm not seeing a valid signature on the tar.gz files. The zips are fine. It looks like you did all of the signing on the tar files and not the tar.gz files.
>> 
>> $ gpg --verify poi-bin-3.8-beta4-20110826.tar.gz.asc
>> gpg: Signature made Tue Aug 23 11:26:14 2011 PDT using DSA key ID F5BB52CD
>> gpg: BAD signature from "Yegor Kozlov <ye...@gmail.com>"
>> 
>> $ gpg --verify poi-bin-3.8-beta4-20110826.zip.asc
>> gpg: Signature made Tue Aug 23 11:26:16 2011 PDT using DSA key ID F5BB52CD
>> gpg: Good signature from "Yegor Kozlov <ye...@gmail.com>"
>> gpg:                 aka "Yegor Kozlov <ye...@dinom.ru>"
>> gpg:                 aka "Yegor Kozlov <ye...@apache.org>"
>> 
>> It looks like you signed poi-bin-3.8-beta4-20110826.tar and not poi-bin-3.8-beta4-20110826.tar.gz
>> 
>> The sha1 hash matches that of the tar and no the tar.gz
>> 
>> $ more poi-bin-3.8-beta4-20110826.tar.gz.sha1
>> 44eb9badbe80b99768b8d821d74b106dc8c5a2c0 *poi-bin-3.8-beta4-20110826.tar.gz
>> 
>> $ openssl sha1 poi-bin-3.8-beta4-20110826.tar
>> SHA1(poi-bin-3.8-beta4-20110826.tar)= 44eb9badbe80b99768b8d821d74b106dc8c5a2c0
>> 
>> Rename the tar.gz.asc to tar.asc and the signature checks.
>> 
>> $ gpg --verify poi-src-3.8-beta4-20110826.tar.asc
>> gpg: Signature made Tue Aug 23 11:26:27 2011 PDT using DSA key ID F5BB52CD
>> gpg: Good signature from "Yegor Kozlov <ye...@gmail.com>"
>> gpg:                 aka "Yegor Kozlov <ye...@dinom.ru>"
>> gpg:                 aka "Yegor Kozlov <ye...@apache.org>"
>> 
>> 
>> I am using this GPG: http://www.gpgtools.org/installer/index.html
>> 
>> And this reference for SHA1 hash - http://support.apple.com/kb/ht1652
>> 
>> Regards,
>> Dave
>> 
>> On Aug 23, 2011, at 12:04 PM, Yegor Kozlov wrote:
>> 
>>> Hi All,
>>> 
>>> Please test-drive the release candidate for POI 3.8 beta4 (take 2).
>>> Compared to the first version, two release blockers have been found and fixed:
>>> 
>>> (1) https://issues.apache.org/bugzilla/show_bug.cgi?id=51686
>>> (2) Our collection of test files included a document that we are not
>>> allowed to distribute.  The doc in question has been removed.
>>> 
>>> The release candidate files are available from:
>>> 
>>> https://dist.apache.org/repos/dist/dev/poi/
>>> 
>>> (The jars and poms to feed into the maven repo are in /maven/
>>> directory, they will be pushed using mvn-deploy.sh)
>>> 
>>> As with all Apache release votes, please check that not only does the
>>> code work, and no major breakages have occurred since the last
>>> release, but also that packaging is correct, license headers and
>>> notices exist etc.
>>> 
>>> The vote options are:
>>> 
>>> +1 - I support this release
>>> 0 - I don't object to this release, but I haven't checked it
>>> -1 - There's a problem with the release, and that is ....
>>> 
>>> I'm voting [+1]. Vote open for 72 hours and ends on Friday, 26th August.
>>> 
>>> Yegor
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>>> For additional commands, e-mail: dev-help@poi.apache.org
>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>> For additional commands, e-mail: dev-help@poi.apache.org
>> 
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Dave Fisher <da...@comcast.net>.
Hi Yegor,

No trouble for the vote since I was able to confirm the signature even if in a strange manner.

I did notice something that we will need to fix before the full release. We need to make Forrest add Apache license headers to the docs html files. Such fun participating with Apache OpenOffice.org and Apache ODF Toolkit :-D

Best Regards,
Dace

On Aug 23, 2011, at 11:14 PM, Yegor Kozlov wrote:

> All the signatures are correct. I used the same signing procedure as
> for old releases, it signs all files in a batch and I didn't do
> anything different for .zip and .gz files. Moreover, I used
> multisign.sh which is a tried and tested script from the release
> tools, see  tools/releases/multisign.sh in the ASF committers
> repository.
> 
> I think it is a problem in the GPGTools for Mac OS X.
> 
> I'm checking with with GNU gpg on Windows / cygwin and on Linux and
> all signatures are fine.
> 
> Yegor
> 
> On Wed, Aug 24, 2011 at 5:34 AM, Dave Fisher <da...@comcast.net> wrote:
>> Hi Yegor,
>> 
>> I'm not seeing a valid signature on the tar.gz files. The zips are fine. It looks like you did all of the signing on the tar files and not the tar.gz files.
>> 
>> $ gpg --verify poi-bin-3.8-beta4-20110826.tar.gz.asc
>> gpg: Signature made Tue Aug 23 11:26:14 2011 PDT using DSA key ID F5BB52CD
>> gpg: BAD signature from "Yegor Kozlov <ye...@gmail.com>"
>> 
>> $ gpg --verify poi-bin-3.8-beta4-20110826.zip.asc
>> gpg: Signature made Tue Aug 23 11:26:16 2011 PDT using DSA key ID F5BB52CD
>> gpg: Good signature from "Yegor Kozlov <ye...@gmail.com>"
>> gpg:                 aka "Yegor Kozlov <ye...@dinom.ru>"
>> gpg:                 aka "Yegor Kozlov <ye...@apache.org>"
>> 
>> It looks like you signed poi-bin-3.8-beta4-20110826.tar and not poi-bin-3.8-beta4-20110826.tar.gz
>> 
>> The sha1 hash matches that of the tar and no the tar.gz
>> 
>> $ more poi-bin-3.8-beta4-20110826.tar.gz.sha1
>> 44eb9badbe80b99768b8d821d74b106dc8c5a2c0 *poi-bin-3.8-beta4-20110826.tar.gz
>> 
>> $ openssl sha1 poi-bin-3.8-beta4-20110826.tar
>> SHA1(poi-bin-3.8-beta4-20110826.tar)= 44eb9badbe80b99768b8d821d74b106dc8c5a2c0
>> 
>> Rename the tar.gz.asc to tar.asc and the signature checks.
>> 
>> $ gpg --verify poi-src-3.8-beta4-20110826.tar.asc
>> gpg: Signature made Tue Aug 23 11:26:27 2011 PDT using DSA key ID F5BB52CD
>> gpg: Good signature from "Yegor Kozlov <ye...@gmail.com>"
>> gpg:                 aka "Yegor Kozlov <ye...@dinom.ru>"
>> gpg:                 aka "Yegor Kozlov <ye...@apache.org>"
>> 
>> 
>> I am using this GPG: http://www.gpgtools.org/installer/index.html
>> 
>> And this reference for SHA1 hash - http://support.apple.com/kb/ht1652
>> 
>> Regards,
>> Dave
>> 
>> On Aug 23, 2011, at 12:04 PM, Yegor Kozlov wrote:
>> 
>>> Hi All,
>>> 
>>> Please test-drive the release candidate for POI 3.8 beta4 (take 2).
>>> Compared to the first version, two release blockers have been found and fixed:
>>> 
>>> (1) https://issues.apache.org/bugzilla/show_bug.cgi?id=51686
>>> (2) Our collection of test files included a document that we are not
>>> allowed to distribute.  The doc in question has been removed.
>>> 
>>> The release candidate files are available from:
>>> 
>>> https://dist.apache.org/repos/dist/dev/poi/
>>> 
>>> (The jars and poms to feed into the maven repo are in /maven/
>>> directory, they will be pushed using mvn-deploy.sh)
>>> 
>>> As with all Apache release votes, please check that not only does the
>>> code work, and no major breakages have occurred since the last
>>> release, but also that packaging is correct, license headers and
>>> notices exist etc.
>>> 
>>> The vote options are:
>>> 
>>> +1 - I support this release
>>> 0 - I don't object to this release, but I haven't checked it
>>> -1 - There's a problem with the release, and that is ....
>>> 
>>> I'm voting [+1]. Vote open for 72 hours and ends on Friday, 26th August.
>>> 
>>> Yegor
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>>> For additional commands, e-mail: dev-help@poi.apache.org
>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>> For additional commands, e-mail: dev-help@poi.apache.org
>> 
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Yegor Kozlov <ye...@dinom.ru>.
All the signatures are correct. I used the same signing procedure as
for old releases, it signs all files in a batch and I didn't do
anything different for .zip and .gz files. Moreover, I used
multisign.sh which is a tried and tested script from the release
tools, see  tools/releases/multisign.sh in the ASF committers
repository.

I think it is a problem in the GPGTools for Mac OS X.

I'm checking with with GNU gpg on Windows / cygwin and on Linux and
all signatures are fine.

Yegor

On Wed, Aug 24, 2011 at 5:34 AM, Dave Fisher <da...@comcast.net> wrote:
> Hi Yegor,
>
> I'm not seeing a valid signature on the tar.gz files. The zips are fine. It looks like you did all of the signing on the tar files and not the tar.gz files.
>
> $ gpg --verify poi-bin-3.8-beta4-20110826.tar.gz.asc
> gpg: Signature made Tue Aug 23 11:26:14 2011 PDT using DSA key ID F5BB52CD
> gpg: BAD signature from "Yegor Kozlov <ye...@gmail.com>"
>
> $ gpg --verify poi-bin-3.8-beta4-20110826.zip.asc
> gpg: Signature made Tue Aug 23 11:26:16 2011 PDT using DSA key ID F5BB52CD
> gpg: Good signature from "Yegor Kozlov <ye...@gmail.com>"
> gpg:                 aka "Yegor Kozlov <ye...@dinom.ru>"
> gpg:                 aka "Yegor Kozlov <ye...@apache.org>"
>
> It looks like you signed poi-bin-3.8-beta4-20110826.tar and not poi-bin-3.8-beta4-20110826.tar.gz
>
> The sha1 hash matches that of the tar and no the tar.gz
>
> $ more poi-bin-3.8-beta4-20110826.tar.gz.sha1
> 44eb9badbe80b99768b8d821d74b106dc8c5a2c0 *poi-bin-3.8-beta4-20110826.tar.gz
>
> $ openssl sha1 poi-bin-3.8-beta4-20110826.tar
> SHA1(poi-bin-3.8-beta4-20110826.tar)= 44eb9badbe80b99768b8d821d74b106dc8c5a2c0
>
> Rename the tar.gz.asc to tar.asc and the signature checks.
>
> $ gpg --verify poi-src-3.8-beta4-20110826.tar.asc
> gpg: Signature made Tue Aug 23 11:26:27 2011 PDT using DSA key ID F5BB52CD
> gpg: Good signature from "Yegor Kozlov <ye...@gmail.com>"
> gpg:                 aka "Yegor Kozlov <ye...@dinom.ru>"
> gpg:                 aka "Yegor Kozlov <ye...@apache.org>"
>
>
> I am using this GPG: http://www.gpgtools.org/installer/index.html
>
> And this reference for SHA1 hash - http://support.apple.com/kb/ht1652
>
> Regards,
> Dave
>
> On Aug 23, 2011, at 12:04 PM, Yegor Kozlov wrote:
>
>> Hi All,
>>
>> Please test-drive the release candidate for POI 3.8 beta4 (take 2).
>> Compared to the first version, two release blockers have been found and fixed:
>>
>> (1) https://issues.apache.org/bugzilla/show_bug.cgi?id=51686
>> (2) Our collection of test files included a document that we are not
>> allowed to distribute.  The doc in question has been removed.
>>
>> The release candidate files are available from:
>>
>> https://dist.apache.org/repos/dist/dev/poi/
>>
>> (The jars and poms to feed into the maven repo are in /maven/
>> directory, they will be pushed using mvn-deploy.sh)
>>
>> As with all Apache release votes, please check that not only does the
>> code work, and no major breakages have occurred since the last
>> release, but also that packaging is correct, license headers and
>> notices exist etc.
>>
>> The vote options are:
>>
>> +1 - I support this release
>> 0 - I don't object to this release, but I haven't checked it
>> -1 - There's a problem with the release, and that is ....
>>
>> I'm voting [+1]. Vote open for 72 hours and ends on Friday, 26th August.
>>
>> Yegor
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>> For additional commands, e-mail: dev-help@poi.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Release POI 3.8 beta4 - Take 2

Posted by Dave Fisher <da...@comcast.net>.
Hi Yegor,

I'm not seeing a valid signature on the tar.gz files. The zips are fine. It looks like you did all of the signing on the tar files and not the tar.gz files.

$ gpg --verify poi-bin-3.8-beta4-20110826.tar.gz.asc
gpg: Signature made Tue Aug 23 11:26:14 2011 PDT using DSA key ID F5BB52CD
gpg: BAD signature from "Yegor Kozlov <ye...@gmail.com>"

$ gpg --verify poi-bin-3.8-beta4-20110826.zip.asc
gpg: Signature made Tue Aug 23 11:26:16 2011 PDT using DSA key ID F5BB52CD
gpg: Good signature from "Yegor Kozlov <ye...@gmail.com>"
gpg:                 aka "Yegor Kozlov <ye...@dinom.ru>"
gpg:                 aka "Yegor Kozlov <ye...@apache.org>"

It looks like you signed poi-bin-3.8-beta4-20110826.tar and not poi-bin-3.8-beta4-20110826.tar.gz

The sha1 hash matches that of the tar and no the tar.gz

$ more poi-bin-3.8-beta4-20110826.tar.gz.sha1
44eb9badbe80b99768b8d821d74b106dc8c5a2c0 *poi-bin-3.8-beta4-20110826.tar.gz

$ openssl sha1 poi-bin-3.8-beta4-20110826.tar
SHA1(poi-bin-3.8-beta4-20110826.tar)= 44eb9badbe80b99768b8d821d74b106dc8c5a2c0

Rename the tar.gz.asc to tar.asc and the signature checks.

$ gpg --verify poi-src-3.8-beta4-20110826.tar.asc
gpg: Signature made Tue Aug 23 11:26:27 2011 PDT using DSA key ID F5BB52CD
gpg: Good signature from "Yegor Kozlov <ye...@gmail.com>"
gpg:                 aka "Yegor Kozlov <ye...@dinom.ru>"
gpg:                 aka "Yegor Kozlov <ye...@apache.org>"


I am using this GPG: http://www.gpgtools.org/installer/index.html

And this reference for SHA1 hash - http://support.apple.com/kb/ht1652

Regards,
Dave

On Aug 23, 2011, at 12:04 PM, Yegor Kozlov wrote:

> Hi All,
> 
> Please test-drive the release candidate for POI 3.8 beta4 (take 2).
> Compared to the first version, two release blockers have been found and fixed:
> 
> (1) https://issues.apache.org/bugzilla/show_bug.cgi?id=51686
> (2) Our collection of test files included a document that we are not
> allowed to distribute.  The doc in question has been removed.
> 
> The release candidate files are available from:
> 
> https://dist.apache.org/repos/dist/dev/poi/
> 
> (The jars and poms to feed into the maven repo are in /maven/
> directory, they will be pushed using mvn-deploy.sh)
> 
> As with all Apache release votes, please check that not only does the
> code work, and no major breakages have occurred since the last
> release, but also that packaging is correct, license headers and
> notices exist etc.
> 
> The vote options are:
> 
> +1 - I support this release
> 0 - I don't object to this release, but I haven't checked it
> -1 - There's a problem with the release, and that is ....
> 
> I'm voting [+1]. Vote open for 72 hours and ends on Friday, 26th August.
> 
> Yegor
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org