You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/18 09:51:33 UTC
[GitHub] [solr] asalamon74 opened a new pull request #27: SOLR-15002 Upgrade httpclient to 4.5.13 and httpcore to 4.4.13
asalamon74 opened a new pull request #27:
URL: https://github.com/apache/solr/pull/27
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
Originally I uploaded the pull request to lucene-solr: apache/lucene-solr#2082 after the split I reupload it to solr (lucene part is already committed)
# Description
Upgrade HttpClient 4.5.13 and HttpCore 4.4.13
# Solution
Upgrade HttpClient 4.5.13 and HttpCore 4.4.13
# Tests
Unit tests
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] janhoy merged pull request #27: SOLR-15002 Upgrade httpclient to 4.5.13 and httpcore to 4.4.13
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #27:
URL: https://github.com/apache/solr/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] asalamon74 commented on pull request #27: SOLR-15002 Upgrade httpclient to 4.5.13 and httpcore to 4.4.13
Posted by GitBox <gi...@apache.org>.
asalamon74 commented on pull request #27:
URL: https://github.com/apache/solr/pull/27#issuecomment-805614123
I have run `./gradlew check` which executes the tests as far as I know. But I'm ready to execute a `./gradlew test` if that runs more tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] janhoy commented on pull request #27: SOLR-15002 Upgrade httpclient to 4.5.13 and httpcore to 4.4.13
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #27:
URL: https://github.com/apache/solr/pull/27#issuecomment-805605179
Have you run all the Solr tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] asalamon74 commented on pull request #27: SOLR-15002 Upgrade httpclient to 4.5.13 and httpcore to 4.4.13
Posted by GitBox <gi...@apache.org>.
asalamon74 commented on pull request #27:
URL: https://github.com/apache/solr/pull/27#issuecomment-805646790
Just to be sure, I executed `./gradlew test`. I had one failure, but this test also fails with this seed on the main branch, so this is not related.
```
./gradlew test --tests StreamDecoratorTest.testParallelPriorityStream -Dtests.seed=3D9A6253043D43BB -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=az-Latn -Dtests.timezone=Etc/GMT-1 -Dtests.asserts=true -Dtests.file.encoding=UTF-8
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] janhoy commented on pull request #27: SOLR-15002 Upgrade httpclient to 4.5.13 and httpcore to 4.4.13
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #27:
URL: https://github.com/apache/solr/pull/27#issuecomment-805030285
Please add a line to CHANGES.txt for 9.0 version and then we can merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] asalamon74 commented on pull request #27: SOLR-15002 Upgrade httpclient to 4.5.13 and httpcore to 4.4.13
Posted by GitBox <gi...@apache.org>.
asalamon74 commented on pull request #27:
URL: https://github.com/apache/solr/pull/27#issuecomment-814159775
I rebased it to fix the CHANGES.txt conflict. @janhoy can you please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org