[GitHub] [thrift] iceprosurface commented on pull request #2673: THRIFT-5634: thrift docs picture was broken

[GitBox <gi...@apache.org>]

iceprosurface commented on PR #2673:
URL: https://github.com/apache/thrift/pull/2673#issuecomment-1253280760

   > i wonder what is a better fix, to change all relative paths to absolute one or to just update somewhere once to fix the `docs` prefix?
   
   This is determined by the location of the static resource (image).
   
   For example:
   
   `https://thrift.apache.org/docs/Languages.html` was under `/docs/`, so that relative assets will load with prefix  `/docs/`
   
   `doc/images/cgrn.png`-> `/docs/doc/images/cgrn.png` ❌
   
   However if we change correct relative path -> `../doc/images/cgrn.png`, this will break github preview. 
   
   
   Move `doc/images` to `docs/images`, then add the `/docs` prefix to every static resource(image), maybe this is a better fix.
   
   Change all doc will break search result of search engine.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org