You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "dev-donghwan (via GitHub)" <gi...@apache.org> on 2026/08/03 11:13:24 UTC
[PR] [ZEPPELIN-6483][FOLLOWUP] Format HDFS modification time with Locale.ROOT [zeppelin]
dev-donghwan opened a new pull request, #5370:
URL: https://github.com/apache/zeppelin/pull/5370
### What is this PR for?
Follow-up to #5351, addressing the non-blocking nit from the [approving review](https://github.com/apache/zeppelin/pull/5351#pullrequestreview-top): `new SimpleDateFormat(pattern)` still takes its calendar and digits from the JVM default *locale*, so the same class of environment dependence survives the GMT fix — e.g. under a `th-TH` default locale the Buddhist calendar renders 2015 as `2558-08-02 20:43GMT`.
This change passes `Locale.ROOT` to the formatter in `listDate()` so the calendar and digits are stable regardless of the JVM default locale, exactly as suggested in the review.
The new test mirrors the structure of `testListDateFormatsInGmtToMatchLabel` (save/restore of the global default in `finally`), switching the default locale to `th-TH` and asserting the listing still shows `2015-08-02 20:43GMT`. Reverting only the `listDate()` change makes it fail with the Buddhist-calendar output (`2558-08-02 20:43GMT`), so it pins the regression rather than asserting current behaviour.
### What type of PR is it?
Improvement
### Todos
* [x] - Pass `Locale.ROOT` to the `SimpleDateFormat` in `listDate()`
* [x] - Add a regression test that fails without the fix
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-6483 (resolved by #5351; this is the follow-up allowed in its review)
### How should this be tested?
* `./mvnw test -pl file -Dtest=HDFSFileInterpreterTest` — 8 tests green (7 existing + 1 new)
* Verified locally that reverting only the `listDate()` change makes `testListDateFormatsWithRootLocale` fail with `2558-08-02 20:43GMT` (Buddhist calendar year) in the listing
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6483][FOLLOWUP] Format HDFS modification time with Locale.ROOT [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5370:
URL: https://github.com/apache/zeppelin/pull/5370#issuecomment-5167680083
Merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6483][FOLLOWUP] Format HDFS modification time with Locale.ROOT [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #5370:
URL: https://github.com/apache/zeppelin/pull/5370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org