[GitHub] [superset] etr2460 commented on a change in pull request #17474: chore: migrate Fieldset component from jsx to tsx

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #17474:
URL: https://github.com/apache/superset/pull/17474#discussion_r752417372



##########
File path: superset-frontend/src/components/Form/Form.tsx
##########
@@ -29,7 +29,7 @@ const StyledForm = styled(AntDForm)`
   }
 `;
 
-export default function Form(props: FormProps) {
+export default function Form(props: any) {

Review comment:
       I think we should keep this type checking. it seems to reveal a bug, as `componentClass="fieldset"` is passed into Form in the `Fieldset`component, but isn't expected on the Form. My guess would be that this does nothing at all and we should remove that prop setting from `Fieldset`, but it's also possible that this is undocumented behavior in antd. I'd recommend looking into how this renders, and see if anything actually has that `fieldset` class on it. If not, then it's probably safe to remove the setting of that prop (since according to TS, it didn't do anything in the first place)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org