You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/02 08:28:25 UTC
[GitHub] [arrow] pitrou commented on a change in pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
pitrou commented on a change in pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#discussion_r533978049
##########
File path: cpp/src/parquet/encoding_test.cc
##########
@@ -495,7 +488,9 @@ class TestArrowBuilderDecoding : public ::testing::Test {
void CheckDecodeArrowNonNullUsingDenseBuilder() {
for (auto np : null_probabilities_) {
InitTestCase(np);
- SKIP_TEST_IF(null_count_ > 0)
+ if (null_count_ > 0) {
+ GTEST_SKIP();
Review comment:
This should probably be `continue` instead.
##########
File path: cpp/src/parquet/encoding_test.cc
##########
@@ -508,7 +503,9 @@ class TestArrowBuilderDecoding : public ::testing::Test {
void CheckDecodeArrowNonNullUsingDictBuilder() {
for (auto np : null_probabilities_) {
InitTestCase(np);
- SKIP_TEST_IF(null_count_ > 0)
+ if (null_count_ > 0) {
+ GTEST_SKIP();
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org