[GitHub] [tvm] lhutton1 edited a comment on pull request #9299: [microNPU] Fix typo in depthwise to allow int8 weights

[GitBox <gi...@apache.org>]

lhutton1 edited a comment on pull request #9299:
URL: https://github.com/apache/tvm/pull/9299#issuecomment-948626646


   Hi @Mousius, yes, currently you can remove `ICHECK` without affecting the tests, since we only test legal combinations of input datatypes at this level.
   
   However, I'm not too sure I follow. I understand `ICHECK` is an assertion. A test could be added to check that the assertion was fired for incorrect datatypes but I don't think that's good practice, since assertions should only exist as a programmer aid. They're also only triggered in a debug build, so the test would fail if this is not the case. Furthermore, interaction from a user perspective should mean this assertion is never encountered since we only pattern match and offload the operations (and compatible attributes) that are supported by the microNPU. Incompatible operations should never reach this level, and so the assertion shouldn't get triggered unless there is a programmer error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org